Skip to content

Conversation

JeffLuoo
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Rename metric prefixed with inference_model to inference_objective.

Which issue(s) this PR fixes:

Fixes #1566

Does this PR introduce a user-facing change?:

rename metric prefix from `inference_model` to `inference_objective`.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 10, 2025
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit fd278a1
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c1dede2a84fa00080ac045
😎 Deploy Preview https://deploy-preview-1567--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kfswain
Copy link
Collaborator

kfswain commented Sep 10, 2025

This LGTM from the standpoint of a rename. We can probably take a longer term AI on if we want to reshape the metrics we output. But I'll leave that to you @JeffLuoo to decide when/how

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeffLuoo, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7108536 into kubernetes-sigs:main Sep 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename inference_model metric prefix to inference_objective

3 participants