Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

@nirrozenbaum nirrozenbaum commented Sep 11, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
recently, a PR was merged by mistake to release 1.0 branch.
As a result, the maintainers team decided to have automated marking of such PRs (that are targeting branch other than main), with an appropriate hold label.
This PR adds hold labels, making sure the maintainers team doesn't miss it if it happens again.

Which issue(s) this PR fixes:

Fixes #1562

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 11, 2025
Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit ca3d16c
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c26cdd39182f000811db89
😎 Deploy Preview https://deploy-preview-1570--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2025
@nirrozenbaum nirrozenbaum changed the title added github action to add a hold label when PRs are pushed to branch… added github action to add a hold label when PRs are pushed to branch other than main Sep 11, 2025
@nirrozenbaum nirrozenbaum changed the title added github action to add a hold label when PRs are pushed to branch other than main add a hold label when PRs are pushed to branch other than main Sep 11, 2025
@kfswain
Copy link
Collaborator

kfswain commented Sep 11, 2025

Awesome!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit a7d943e into kubernetes-sigs:main Sep 11, 2025
16 checks passed
@nirrozenbaum nirrozenbaum deleted the non-main-gatekeeper branch September 12, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tags to PRs to non-main branches

3 participants