-
Notifications
You must be signed in to change notification settings - Fork 182
Conformance: Adds v1.0.0 Gateway Conformance Report for Kgateway #1579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance: Adds v1.0.0 Gateway Conformance Report for Kgateway #1579
Conversation
Signed-off-by: Daneyon Hansen <[email protected]>
@danehans: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
- The [kubectl](https://kubernetes.io/docs/tasks/tools/) command-line tool installed and configured for the active cluster context. | ||
- The [helm](https://github.com/helm/helm), [git](https://git-scm.com/downloads), and [make](https://www.gnu.org/software/make/) command-line tools installed. | ||
|
||
### Steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we move the steps to run into kgateway repo and put here only a link?
not a blocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so. This pattern aligns with Gateway API conformance tests.
cc: @robscott
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
Optionally add one or more of the following kinds if applicable:
/area conformance-test
What this PR does / why we need it:
Adds a v1.0.0 gateway conformance report for the kgateway implementation.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: