-
Notifications
You must be signed in to change notification settings - Fork 182
Conformance: Adds Report for Kgateway with Agentgateway #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance: Adds Report for Kgateway with Agentgateway #1587
Conversation
@danehans: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hold until:
/hold |
Removing the hold:
/unhold |
cb9b0dd
to
fecb389
Compare
Signed-off-by: Daneyon Hansen <[email protected]>
fecb389
to
67925a4
Compare
/test pull-gateway-api-inference-extension-test-unit-main |
organization: kgateway-dev | ||
project: kgateway | ||
url: github.com/kgateway-dev/kgateway | ||
version: v2.1.0-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this version mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tip of the kgateway main branch. We have not cut the kgateway v2.1.0 release. I will update the conformance report to v2.1.0
when the release is cut (~2 weeks).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably aim to add a requirement that this points to a specific point in time so it's truly reproducible, but don't want to block this report on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danehans!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @danehans! /lgtm |
What type of PR is this?
/kind test
/area conformance-test
What this PR does / why we need it:
Adds a v1.0.0 conformance profile and reproducer steps for kgateway with agentgateway data plane.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: