Skip to content

Conversation

danehans
Copy link
Contributor

What type of PR is this?
/kind test
/area conformance-test

What this PR does / why we need it:

Adds a v1.0.0 conformance profile and reproducer steps for kgateway with agentgateway data plane.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

@danehans: The label(s) kind/test, area/conformance-test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind test
/area conformance-test

What this PR does / why we need it:

Adds a v1.0.0 conformance profile and reproducer steps for kgateway with agentgateway data plane.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 14, 2025
Copy link

netlify bot commented Sep 14, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 67925a4
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c856d74cbf1a0008564add
😎 Deploy Preview https://deploy-preview-1587--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2025
@danehans
Copy link
Contributor Author

danehans commented Sep 14, 2025

Hold until:

  1. Pass missing override destination to load balancer agentgateway/agentgateway#438 merges
  2. agentgateway publishes a release with ^ PR.
  3. kgateway consumes the above agentgateway release.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2025
@danehans
Copy link
Contributor Author

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2025
@danehans danehans force-pushed the agtw_conform_report_gie_v1 branch from cb9b0dd to fecb389 Compare September 15, 2025 18:09
@danehans danehans force-pushed the agtw_conform_report_gie_v1 branch from fecb389 to 67925a4 Compare September 15, 2025 18:11
@danehans
Copy link
Contributor Author

/test pull-gateway-api-inference-extension-test-unit-main

organization: kgateway-dev
project: kgateway
url: github.com/kgateway-dev/kgateway
version: v2.1.0-main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this version mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tip of the kgateway main branch. We have not cut the kgateway v2.1.0 release. I will update the conformance report to v2.1.0 when the release is cut (~2 weeks).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably aim to add a requirement that this points to a specific point in time so it's truly reproducible, but don't want to block this report on that.

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danehans!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

Thanks @danehans!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 771dc5e into kubernetes-sigs:main Sep 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants