Rename prefix scorer HashBlockSize to BlockSize

[Frapschen]

What type of PR is this?

This is a breaking change.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1559

Does this PR introduce a user-facing change?:

Rename prefix scorer HashBlockSize to BlockSize

[netlify]

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	74e9744
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68cbc296fdd1eb0008168dd5
😎 Deploy Preview	https://deploy-preview-1613--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

Hi @Frapschen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JaredTan95]

It seems that this is a breaking change for end users?

[nirrozenbaum]

/ok-to-test

[nirrozenbaum]

It seems that this is a breaking change for end users?

Each plugin may have parameters (it’s optional).
this change rename an optional parameter of the prefix cache scorer (which is a plugin).
this is a user facing change, but not in a sense of the users that send requests to IGW. it’s a change for whoever configures the system.

/approve

this change lgtm, @liu-cong can you review to make sure it’s aligned with your intention?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Frapschen, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nirrozenbaum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liu-cong]

/lgtm

Thank you!

It seems that this is a breaking change for end users?

Just to add to @nirrozenbaum 's points. For this particular config, it's optional AND I expect more users to just take the default value.

But this is a great point, although we may not need to treat plugin configs as strong as CRDs, I think certain level of stability and some notification mechanism for changes is important, especially for non-optional configs, or configs that might have huge impacts. Will create an issue for that follow up.

[liu-cong]

This is the issue to discuss future changes to plugin config #1621

[DamianSawicki]

Thank you very much @Frapschen and @liu-cong for fixing that confusing parameter name, I appreciate it!