-
Notifications
You must be signed in to change notification settings - Fork 182
Remove duplicate gcpbackendpolicy and healthcheckpolicy config #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@kfswain Another bug fix for the patch. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, liu-cong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This doesn't require a patch since those manifests are not part of the release. |
++ |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fix 2 bugs:
EDIT: The first bug is already fixed by #1600
monitoring.gke.enabled
field to values.yaml, otherwise helm apply will fail withhealthcheckpolicy
andgcpbackendpolicy
from the static manifest. These are already added to the helm chart withprovider=gke
. Currently following the user guide will result in duplicated healthcheckpolicy and gcpbackendpolicy for GKE, and users need to manually dedupe for gateway to function.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: