Skip to content

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Sep 19, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR fix 2 bugs:

EDIT: The first bug is already fixed by #1600

  1. Add monitoring.gke.enabled field to values.yaml, otherwise helm apply will fail with
Error: UPGRADE FAILED: template: inferencepool/templates/epp-sa-token-secret.yaml:1:74: executing "inferencepool/templates/epp-sa-token-secret.yaml" at <.Values.inferenceExtension.monitoring.gke.enabled>: nil pointer evaluating interface {}.enabled
  1. Remove the healthcheckpolicy and gcpbackendpolicy from the static manifest. These are already added to the helm chart with provider=gke. Currently following the user guide will result in duplicated healthcheckpolicy and gcpbackendpolicy for GKE, and users need to manually dedupe for gateway to function.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2025
Copy link

netlify bot commented Sep 19, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 03af21b
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68cd9afe8360b60007e51b81
😎 Deploy Preview https://deploy-preview-1618--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2025
@liu-cong liu-cong changed the title Fix bugs in GKE monitoring and healthcheck config Remove duplicate gcpbackendpolicy and healthcheckpolicy config Sep 19, 2025
@liu-cong
Copy link
Contributor Author

@kfswain Another bug fix for the patch.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 19, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Sep 19, 2025

@kfswain Another bug fix for the patch.

This doesn't require a patch since those manifests are not part of the release.

@kfswain
Copy link
Collaborator

kfswain commented Sep 19, 2025

@kfswain Another bug fix for the patch.

This doesn't require a patch since those manifests are not part of the release.

++

@k8s-ci-robot k8s-ci-robot merged commit b4a418c into kubernetes-sigs:main Sep 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants