Skip to content

Conversation

learner0810
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Auto-configure prefix-cache-scorer parameters from engine metrics

Which issue(s) this PR fixes:

Fixes # partial fix: #1512

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 22, 2025
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit d50488a
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68d201a55f74050008a42b3f
😎 Deploy Preview https://deploy-preview-1629--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: learner0810
Once this PR has been reviewed and has the lgtm label, please assign danehans for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @learner0810. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 22, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Sep 22, 2025

/assign @liu-cong
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 22, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Sep 22, 2025

@learner0810 do we have a similar metric in sglang?

@learner0810 learner0810 force-pushed the auto-configure-prefix-cache-scorer-parameters branch from 76971e1 to d50488a Compare September 23, 2025 02:10
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2025
@learner0810
Copy link
Contributor Author

@learner0810 do we have a similar metric in sglang?

I looked up the sglang documentation and didn't find it, so it probably isn't there yet.

@learner0810
Copy link
Contributor Author

cc @liu-cong PTAL

LoraInfoWaitingAdaptersMetricName = "waiting_lora_adapters"
LoraInfoMaxAdaptersMetricName = "max_lora"

CacheConfigBlockSizeInfoMetricName = "block_size"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan to add the cache size metric as well? maybe in a follow up PR? That's a much more useful metric than the block size. In fact, the block size doesn't necessarily need to be the same with vllm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, If IGW requires cache size metric, I'd be happy to add that in a subsequent pull request.

@liu-cong
Copy link
Contributor

cc @elevran

What's the status of the pluggable data layer? Can we use that to retrieve this new metric(s)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-configure prefix-cache-scorer parameters from engine metrics
4 participants