Adding a flag to control whether auth is added to the EPP metrics server

[Frapschen]

What type of PR is this?
/kind feature

What this PR does / why we need it:

Add a --metrics-endpoint-auth flag to control whether to add auth to the EPP metrics server

Which issue(s) this PR fixes:

Fixes #1637

Does this PR introduce a user-facing change?:

Add a `--metrics-endpoint-auth=false` flag to control whether to add auth to the EPP metrics server

Add --metrics-endpoint-auth=false to your command line when you need to disable the auth of EPP metrics server in local dev.

[netlify]

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	3a3cf79
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68db5315468a51000839450d
😎 Deploy Preview	https://deploy-preview-1639--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

Hi @Frapschen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[liu-cong]

/ok-to-test

[liu-cong]

/lgtm

cc @ahg-g @JeffLuoo This is a nice to have IMO

[JeffLuoo]

/lgtm

As long as we keep the flag default to on, I think should be good.

[nirrozenbaum]

if metrics is not checking auth can we add a conditional to helm not to install the cluster role?
this may help in quick setup when people have admin permission only for a namespace

[Frapschen]

@JeffLuoo Any reason we use PodMonitor in gke.yaml and use ServiceMonitor in epp-servicemonitor.yaml

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[Frapschen]

@nirrozenbaum I have updated the chart template and applied some enhancements.

[JeffLuoo]

@JeffLuoo Any reason we use PodMonitor in gke.yaml and use ServiceMonitor in epp-servicemonitor.yaml

ServiceMonitor is from native Prometheus Operator. PodMonitor is the CRD from Google Managed Prometheus and GKE deploys the Google Managed Prometheus by default in the cluster.

[nirrozenbaum]

@JeffLuoo Any reason we use PodMonitor in gke.yaml and use ServiceMonitor in epp-servicemonitor.yaml

ServiceMonitor is from native Prometheus Operator. PodMonitor is the CRD from Google Managed Prometheus and GKE deploys the Google Managed Prometheus by default in the cluster.

I think gke PodMonitor was added before the ServiceMonitor. do we really need both?

[JeffLuoo]

@JeffLuoo Any reason we use PodMonitor in gke.yaml and use ServiceMonitor in epp-servicemonitor.yaml

ServiceMonitor is from native Prometheus Operator. PodMonitor is the CRD from Google Managed Prometheus and GKE deploys the Google Managed Prometheus by default in the cluster.

I think gke PodMonitor was added before the ServiceMonitor. do we really need both?

Yes. we still need both as PodMonitor is mostly used by GKE unless other cloud provider of Kubernetes want to use Google Managed Prometheus (which I don't see it as the case for now). So other provider will use ServiceMonitor from Prometheus-Operator.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Frapschen, JeffLuoo
Once this PR has been reviewed and has the lgtm label, please assign danehans for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment