-
Notifications
You must be signed in to change notification settings - Fork 176
Update steps to run conformance tests against kgateway #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidjumani The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
``` | ||
|
||
5. Install kgateway with Inference Extension enabled: | ||
6. Install kgateway with Inference Extension enabled: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you switch these all to 1
? Markdown convert them to the proper number for you so then with edits like these, theres no need to backfill
1. Build and load the images: | ||
|
||
```sh | ||
make kind-build-and-load | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building and loading the image should be unneeded since kgateway provides a rolling release (v2.1.0-main), which is used by this document.
What type of PR is this?
Add one of the following kinds:
/kind documentation
What this PR does / why we need it:
This adds the missing step to build and load the images when running the conformance tests against kgateway
Does this PR introduce a user-facing change?: