Skip to content

Conversation

kaushikmitr
Copy link
Contributor

This pull request adds a comprehensive flush API to the training server, enabling manual clearing of training data, test data, and metrics, along with corresponding status and error handling endpoints. The test suite is expanded to cover these new endpoints and behaviors.

Training Server: Flush API and Data Status

  • Implemented a /flush endpoint with a FlushRequest/FlushResponse model, allowing manual clearing of training data, test data, and metrics, with detailed reporting and error handling.
  • Added a /data/status endpoint to report current counts of training/test samples, metrics, and bucket distribution. (latencypredictor-v1/training_server.py)

Testing Enhancements

  • Expanded the test suite to cover the flush API, its error handling, and the data status endpoint, ensuring correct behavior for all flush scenarios. (latencypredictor-v1/test_dual_server_client.py)
  • Updated prediction and training server URLs to use placeholder IPs for easier configuration. (latencypredictor-v1/test_dual_server_client.py)

SLO Scorer: Bug Fix

  • Updated PodPredictionResult to include a PrefixCacheScore field for use to correctly use prefix cache score logic.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 7, 2025
@kaushikmitr
Copy link
Contributor Author

kaushikmitr commented Oct 7, 2025

@kaushikmitr
Copy link
Contributor Author

/retest

bump sigs.k8s.io/controller-runtime from 0.21.0 to 0.22.2

restore go version
@kaushikmitr kaushikmitr force-pushed the slo-prediction-experimental branch from a43571b to 08f4b74 Compare October 8, 2025 00:38
@ahg-g
Copy link
Contributor

ahg-g commented Oct 9, 2025

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kaushikmitr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit b2ddec6 into kubernetes-sigs:slo-prediction-experimental Oct 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants