Skip to content

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Oct 8, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Needed to support latest Gateway API release.

Which issue(s) this PR fixes:
N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and robscott October 8, 2025 05:06
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2025
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 1f6a95a
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68e804b46288530008422897
😎 Deploy Preview https://deploy-preview-1691--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nirrozenbaum
Copy link
Contributor

once the tests failures are fixed I'm happy to stamp.

@nirrozenbaum
Copy link
Contributor

If I remember correctly I think I've seen in one of the slack thread where @aslakknutsen wrote GIE is incompatible with Gateway API v1.4.0. @aslakknutsen I'd be happy if you can chime in if you have more information about that.

@aslakknutsen
Copy link
Contributor

@nirrozenbaum This is was the main issue; https://github.com/kubernetes-sigs/gateway-api-inference-extension/pull/1691/files#diff-31af5d0f8d06f9d6bf0acf99812d75a36b81d883b0797229e095b6c98c16384bR177

Not so much incompatible with 1.4.0 as Gateway API having no guarantee as to the stability of their test framework which is used by GIE as well.

The other one I ran into was the TypeChecker from client-go fixed here 6198b57#diff-03a922bcf42cd06aedba074efb878fe4564184a9bdfcb70f127c0aad76997fedL81

@danehans danehans force-pushed the gw_api_v1.4.0_bump branch from 2150f89 to cd5151e Compare October 9, 2025 18:15
@danehans danehans force-pushed the gw_api_v1.4.0_bump branch from cd5151e to 1f6a95a Compare October 9, 2025 18:53
@danehans
Copy link
Contributor Author

danehans commented Oct 9, 2025

Note that commit 1f6a95a was added since the controller-runtime fake client in v0.22.1 no longer guarantees that TypeMeta (APIVersion, Kind) is populated on objects it returns.

@nirrozenbaum
Copy link
Contributor

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9880663 into kubernetes-sigs:main Oct 9, 2025
11 checks passed
@danehans danehans deleted the gw_api_v1.4.0_bump branch October 9, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants