-
Notifications
You must be signed in to change notification settings - Fork 179
Dep: Bumps Gateway API to v1.4.0 #1691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dep: Bumps Gateway API to v1.4.0 #1691
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
once the tests failures are fixed I'm happy to stamp. |
If I remember correctly I think I've seen in one of the slack thread where @aslakknutsen wrote GIE is incompatible with Gateway API v1.4.0. @aslakknutsen I'd be happy if you can chime in if you have more information about that. |
@nirrozenbaum This is was the main issue; https://github.com/kubernetes-sigs/gateway-api-inference-extension/pull/1691/files#diff-31af5d0f8d06f9d6bf0acf99812d75a36b81d883b0797229e095b6c98c16384bR177 Not so much incompatible with 1.4.0 as Gateway API having no guarantee as to the stability of their test framework which is used by GIE as well. The other one I ran into was the TypeChecker from client-go fixed here 6198b57#diff-03a922bcf42cd06aedba074efb878fe4564184a9bdfcb70f127c0aad76997fedL81 |
Signed-off-by: Daneyon Hansen <[email protected]>
Signed-off-by: Daneyon Hansen <[email protected]>
Signed-off-by: Daneyon Hansen <[email protected]>
2150f89
to
cd5151e
Compare
Signed-off-by: Daneyon Hansen <[email protected]>
cd5151e
to
1f6a95a
Compare
Note that commit 1f6a95a was added since the controller-runtime fake client in v0.22.1 no longer guarantees that TypeMeta (APIVersion, Kind) is populated on objects it returns. |
/lgtm Thanks! |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Needed to support latest Gateway API release.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: