-
Notifications
You must be signed in to change notification settings - Fork 182
Conformance:use gateway api utility functions from v1.4.0 and minor fix typos. #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This change lgtm. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, zetxqx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold This will need some rebase, waiting for other PRs to be merged. |
What type of PR is this?
/area conformance-test
/kind cleanup
What this PR does / why we need it:
With the new gateway-api v1.4.0 released, some utility functions can be used to replace some duplication in the conformance tests. Key things leveraged:
MakeRequestAndExpectEventuallyConsistentResponse
Which issue(s) this PR fixes:
Fixes #1031
Tested against gkegateway:
Does this PR introduce a user-facing change?:
NONE