Skip to content

Fix LabelSelector validation markers for map field #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
+5 −2
Merged

Fix LabelSelector validation markers for map field #1717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ help: ## Display this help.
.PHONY: generate
generate: controller-gen code-generator ## Generate WebhookConfiguration, ClusterRole, CustomResourceDefinition objects, code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate/boilerplate.generatego.txt" paths="./..."
$(CONTROLLER_GEN) crd output:dir="./config/crd/bases" paths="./..."
./hack/update-codegen.sh

# Use same code-generator version as k8s.io/api
Expand Down
4 changes: 2 additions & 2 deletions api/v1/shared_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ type LabelSelector struct {
// The matching logic is an AND operation on all entries.
//
// +required
// +kubebuilder:validation:MinItems=1
// +kubebuilder:validation:MaxItems=64
// +kubebuilder:validation:MinProperties=1
// +kubebuilder:validation:MaxProperties=64
MatchLabels map[LabelKey]LabelValue `json:"matchLabels,omitempty"`
}
2 changes: 2 additions & 0 deletions config/crd/bases/inference.networking.k8s.io_inferencepools.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ spec:
MatchLabels contains a set of required {key,value} pairs.
An object must match every label in this map to be selected.
The matching logic is an AND operation on all entries.
maxProperties: 64
minProperties: 1
type: object
required:
- matchLabels
Expand Down