Fix Minor Issues in Release Tooling #1724
Conversation
Signed-off-by: Daneyon Hansen <[email protected]>
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
approved
|
/lgtm |
| VLLM_GPU="${VLLM_GPU:-0.8.5}" | ||
| # The CPU image is from https://gallery.ecr.aws/q9t5s3a7/vllm-cpu-release-repo | ||
| VLLM_CPU="${VLLM_CPU:-0.10.0}" | ||
| VLLM_CPU="${VLLM_CPU:-0.8.5}" | ||
| # The sim image is from https://github.com/llm-d/llm-d-inference-sim/pkgs/container/llm-d-inference-sim | ||
| VLLM_SIM="${VLLM_SIM:-0.3.2-fix}" | ||
| VLLM_SIM="${VLLM_SIM:-0.4.0}" |
There was a problem hiding this comment.
These are the versions currently used in the release-1.0 branch. In my opinion, they should not get bumped in a patch release unless any of the images contain a bug that should be resolved.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| .PHONY: release | ||
| release: artifacts release-quickstart verify test # Create a release. | ||
| release: artifacts release-quickstart api-ref-docs apix-ref-docs verify test # Create a release. |
There was a problem hiding this comment.
This ensures any changes in the patch release are reflected in the API docs. Although we don't currently have versioned docs, this will be helpful if we do in the future.
3 participants
Fixes minor release tolling issues specific to the release-1.0 branch.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: