-
Notifications
You must be signed in to change notification settings - Fork 195
Enable EPP to support endpoint discovery using pod selector #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable EPP to support endpoint discovery using pod selector #1833
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No need to review it right now. I just made the CUJ of standalone epp work without inferencepool. Still need to fix the e2e and ut |
elevran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cursory review to provide initial feedback (realizing this is work in progress)
The main question I have (and might be worth mentioning in the PR description) is the need for a new abstraction/type (EndPointsPool). A naive/simple solution (which perhaps does not work...) would be to copy the selector and port array into a Go InferencePool object and use datastore.PoolSet() along with disabling the Pool notification/reconciliation so it does not overwrite with nil.
Hopefully the rest of the code should not care or depend on the pool's origin (from command line or the API server)
|
assign @ahg-g for early review. |
|
assign @kfswain for early review |
Signed-off-by: Xiyue Yu <[email protected]>
Do we actually need Given this from #1838:
The Inference Pool is not needed at all in (1) and all reconcilers should be disabled, option (2.1) works well with a "fake" pool that has the minimal attributes set and a no pool reconciler, and (2.2) or later use the full CRD. Ultimately we deal with inference endpoints (BTW: agree with @kfswain comment that the term is not used consistently across and we should make it more explicit). The InferencePool is merely one way to define attributes of service discovery for relevant endpoints. |
|
I think we are going back and forth on a non material issue; both paths are reasonable and one can't argue that the one in this PR is wrong or harmful; it is also an implementation detail that I recommend to empower contributors to make. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, capri-xiyue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
See #1779
Which issue(s) this PR fixes:
Part of #1779
Does this PR introduce a user-facing change?: