some cleanup in runner and config loading + deprecation notes #1880
+30
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
approved
Signed-off-by: Nir Rozenbaum <[email protected]>
shmuelk
suggested changes
Nov 19, 2025
Co-authored-by: Shmuel Kallner <[email protected]>
shmuelk
approved these changes
Nov 19, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, shmuelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
nirrozenbaum
commented
Nov 19, 2025
Comment on lines
-239
to
-241
| customCollectors := []prometheus.Collector{collectors.NewInferencePoolMetricsCollector(datastore)} | ||
| if r.customCollectors != nil { | ||
| customCollectors = append(customCollectors, r.customCollectors...) |
Contributor
Author
There was a problem hiding this comment.
This was a bug -
if custom collectors were used, the collector that emits the EPP's commit sha and version was not registered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: