-
Notifications
You must be signed in to change notification settings - Fork 235
Support selector for InferencePool selection in InferenceObjective
#2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @pierDipi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
nirrozenbaum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierDipi what would happen if the label selector of InfObj is:
labels:
env: prodand then we add this label to an existing pool?
I see no handling of pool changes that trigger a match. am I missing something?
|
I'd like to hold off on this if we can. This doc proposes changes to InferenceObjective that increases its utility beyond simple priority. And so some of the semantics may become pool specific, rather than reusable. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently,
InferenceObjectiverequires a direct reference to a single InferencePool via poolRef. In multi-pool environments, administrators must create duplicateInferenceObjectiveresources for each pool, leading to:Which issue(s) this PR fixes:
Fixes #2202
Does this PR introduce a user-facing change?: