Skip to content

Conversation

@pierDipi
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

Currently, InferenceObjective requires a direct reference to a single InferencePool via poolRef. In multi-pool environments, administrators must create duplicate InferenceObjective resources for each pool, leading to:

  • Configuration sprawl and maintenance burden
  • Potential for configuration drift between pools
  • Difficulty applying consistent priority policies across pool group
  spec:                                                                                                                                                                                                                                                             
    priority: -10                                                                                                                                                                                                                                                    
    poolSelector:             # mutually exclusive with poolRef, within InferenceObjective namespace                                                                                                                                                                                                                                                   
      matchLabels:                                                                                                                                                                                                                                                  
        gradution: beta                                                                                                                                                                                                                                            
      matchExpressions:                                                                                                                                                                                                                                            
        - key: plan                                                                                                                                                                                                                                               
          operator: In                                                                                                                                                                                                                                              
          values: [plus, pro]

Which issue(s) this PR fixes:

Fixes #2202

Does this PR introduce a user-facing change?:

Support selector for `InferencePool` selection in `InferenceObjective`

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 30, 2026
@netlify
Copy link

netlify bot commented Jan 30, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 4c090e2
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/697cfd6195ded70008dd4739
😎 Deploy Preview https://deploy-preview-2238--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pierDipi
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 30, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @pierDipi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 30, 2026
Copy link
Contributor

@nirrozenbaum nirrozenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi what would happen if the label selector of InfObj is:

labels:
  env: prod

and then we add this label to an existing pool?
I see no handling of pool changes that trigger a match. am I missing something?

@kfswain
Copy link
Collaborator

kfswain commented Jan 30, 2026

I'd like to hold off on this if we can.

This doc proposes changes to InferenceObjective that increases its utility beyond simple priority. And so some of the semantics may become pool specific, rather than reusable.
https://docs.google.com/document/d/1JxzJc8gNv2wKK5-a8ohb0btn78ymVKw9XMIb4-S-ncA/edit?tab=t.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add selector support for InferencePool selection in InferenceObjective

4 participants