Skip to content

Mesh resource definition #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 30, 2025
Merged

Mesh resource definition #3950

merged 20 commits into from
Jul 30, 2025
+590 −17

Conversation

kflynn
Copy link
Contributor

@kflynn kflynn commented Jul 23, 2025

This is a minimal GEP for the Mesh resource existing at all.

/kind gep

Fixes #3949

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 23, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 23, 2025
@kflynn kflynn mentioned this pull request Jul 23, 2025
Open
karthikbox
karthikbox reviewed Jul 23, 2025
View reviewed changes
youngnick
youngnick reviewed Jul 24, 2025
View reviewed changes
geps/gep-3949/index.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't make a difference for the eventual rendering of the page, but this currently looks like the raw .md file is in free verse. Is that intended? Non-blocking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've never just, I dunno, wanted a little more poetry in your life?? 🙂

No, I decided to try something I heard about at (I think) KubeCon, relying on the rendered Markdown to be easily readable but splitting up lines semantically to make the diffs easier to deal with. Larger units might work better, but we'll see how the diffs go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea, but my personal preference would be to to split by sentences for a better compromise between smaller diffs and readability. Definitely not a blocker though.

@youngnick
Copy link
Contributor

Couple of small things, but I've wanted a Mesh resource for years, so LGTM. I'll approve here, and leave this held.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025
robscott
robscott reviewed Jul 25, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kflynn! Mostly LGTM, just some nits

geps/gep-3949/index.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea, but my personal preference would be to to split by sentences for a better compromise between smaller diffs and readability. Definitely not a blocker though.

howardjohn
howardjohn reviewed Jul 25, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2025
kflynn added 13 commits July 26, 2025 09:52
@kflynn
GEP-3949, Mesh resource
7ad3e03 
Signed-off-by: Flynn <[email protected]>
@kflynn
Tweak punctuation
dbc2d1b 
Signed-off-by: Flynn <[email protected]>
@kflynn
Update to experimental API group and resource name
cf82eeb 
Signed-off-by: Flynn <[email protected]>
@kflynn
More tweak
0809e15 
Signed-off-by: Flynn <[email protected]>
@kflynn
Indentation fix
0ee67e6 
Signed-off-by: Flynn <[email protected]>
@kflynn
Note that changing GAMMA's position on multiple meshes is a non-goal
a403a68 
Signed-off-by: Flynn <[email protected]>
@kflynn
Review feedback
f942bfa 
Signed-off-by: Flynn <[email protected]>
@kflynn
Fix list-element indentation
d9e19e7 
Signed-off-by: Flynn <[email protected]>
@kflynn
Add a mkdocs.yml entry. 🤦‍♂️
ded3c90 
Signed-off-by: Flynn <[email protected]>
@kflynn
Review feedback
e393c2d 
Signed-off-by: Flynn <[email protected]>
@kflynn
Initial type definition
f4e814a 
Signed-off-by: Flynn <[email protected]>
@kflynn
Drop comment that was breaking rendering?
ef7519a 
Signed-off-by: Flynn <[email protected]>
@kflynn
Tabs -> spaces
ef82550 
Signed-off-by: Flynn <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2025
@kflynn
Review feedback.
0bc0a2b 
Signed-off-by: Flynn <[email protected]>
robscott
robscott approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kflynn - one small comment, otherwise LGTM.

@kflynn
Review feedback
0d3f1ed 
Signed-off-by: Flynn <[email protected]>
@kflynn
Copy link
Contributor Author

kflynn commented Jul 30, 2025

Updated with what I hope is the last bit of feedback, after a Slack discussion with @howardjohn and @keithmattix. 🤞

keithmattix
keithmattix approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this new state could work for Istio

@shaneutt shaneutt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2025
shaneutt
shaneutt approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keithmattix, kflynn, robscott, shaneutt, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [robscott,shaneutt,youngnick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f6f9a3 into kubernetes-sigs:main Jul 30, 2025
19 checks passed
@kflynn kflynn deleted the flynn/gep-3949 branch July 30, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

@karthikbox karthikbox karthikbox left review comments

@youngnick youngnick youngnick left review comments

@robscott robscott robscott approved these changes

@keithmattix keithmattix keithmattix approved these changes

@shaneutt shaneutt shaneutt approved these changes

@candita candita Awaiting requested review from candita

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mesh Resource Definition
9 participants
@kflynn @youngnick @k8s-ci-robot @robscott @howardjohn @keithmattix @karthikbox @shaneutt @LiorLieberman