-
Notifications
You must be signed in to change notification settings - Fork 597
gep: refine ClientCertificateRef description for backend TLS #4123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: snorwin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Norwin Schnyder <[email protected]>
geps/gep-3155/index.md
Outdated
// to be attached. If a ReferenceGrant does not allow this reference, the | ||
// "ResolvedRefs" condition MUST be set to False for this listener with the | ||
// "RefNotPermitted" reason. | ||
// This setting can be overridden on the service level by use of BackendTLSPolicy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement is no longer true. gateway client certificate is part of gateway identity and should be the same for all connections from gateway to backend, this setting cannot be overridden on service level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking the same, but I didn’t want to remove it without discussing it first. If everyone agrees, I’ll go ahead and remove it.
/assign |
Signed-off-by: Norwin Schnyder <[email protected]>
overall lgtm. Will leave final word for approvers :) |
@robscott @youngnick what do you think about adding a I’m interested to hear your thoughts so we can improve the description further. |
What type of PR is this?
/kind gep
What this PR does / why we need it:
In the current version of the GEP-3155, the semantics of an invalid
ClientCertificateRef
are not fully specified.Additionally, the GEP states that an invalid
ClientCertificateRef
affects theResolvedRefs
condition on the Listeners, which I think is incorrect.This PR clarifies the behavior by introducing a
ResolvedRefs
condition on the Gateway instead. That condition will be set whenever aClientCertificateRef
is invalid or not permitted.Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: