Skip to content

Move VAC storage API to v1 from v1beta1. #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Move VAC storage API to v1 from v1beta1. #2175

wants to merge 4 commits into from
+5 −9

Conversation

nathanielford
Copy link

Change-Id: I79888b0ecfb327ac9da788be6b1224c6699400c6

What type of PR is this?

/kind api-change

What this PR does / why we need it:

The feature-gated VAC enhancement (kubernetes/enhancements#3751) will be on by default in the v1 API, which gcp-compute-persistent-disk-csi-driver will support going forward.

Special notes for your reviewer:

This is my first PR, so any feedback you can give me on how to improve any aspect of it will be appreciated!

Does this PR introduce a user-facing change?:

NONE

* Changed: VolumeAttributeClass will now use the v1 API, which allows dynamic configuration of IOPs and throughput on volumes.

nathanielford and others added 3 commits September 22, 2025 20:29
@nathanielford
Move VAC api from v1beta1 to v1
c69bad1 
Change-Id: I79888b0ecfb327ac9da788be6b1224c6699400c6
@nathanielford
Merge branch 'kubernetes-sigs:master' into vac-storage-class-api
2a751aa
@nathanielford
Fix autoformatting issue
1442d64 
Change-Id: I2d78a565098a10fa8c64f6b4ea96f9397462d202
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nathanielford
Once this PR has been reviewed and has the lgtm label, please assign saikat-royc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from leiyiz September 22, 2025 22:59
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nathanielford. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2025
sunnylovestiramisu
sunnylovestiramisu reviewed Sep 23, 2025
View reviewed changes
examples/kubernetes/demo-vol-create.yaml
image: nginx:1.14.2
ports:
- containerPort: 80
- containerPort: 80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the space change? This seems unrelated.

sunnylovestiramisu
sunnylovestiramisu reviewed Sep 23, 2025
View reviewed changes
test/k8s-integration/main.go
// Skip mount options test until we fix the invalid mount options for xfs.
skipString = skipString + "|csi-gcepd-sc-xfs.*provisioning.should.provision.storage.with.mount.options"
// Skip VolumeAttributesClass tests while it's a beta feature.
skipString = skipString + "|\\[Feature:VolumeAttributesClass\\]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 750 there is another skipString = skipString + "|\[Feature:VolumeAttributesClass\]", can you remove that line as well?

@sunnylovestiramisu
Copy link
Contributor

We also need to change the documentation in the OSS repo: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver?tab=readme-ov-file#kubernetes-version-recommendations

Here we need to add a line for HEAD that it supports k/k 1/34+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnylovestiramisu sunnylovestiramisu sunnylovestiramisu left review comments

@leiyiz leiyiz Awaiting requested review from leiyiz

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanielford @k8s-ci-robot @sunnylovestiramisu