Skip to content

[release-1.21] Cache and print devices for debugging future outages #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 30, 2025
Merged

[release-1.21] Cache and print devices for debugging future outages #2185

merged 23 commits into from
Sep 30, 2025
+337 −69

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2141

/assign cemakd

NONE

julianKatz and others added 23 commits September 30, 2025 17:42
@julianKatz
Cache devices and their symlinks in node driver, periodically noting …
701707d 
…changes and printing the full list.

example: periodic symlink cache read:
/dev/disk/by-id/google-persistent-disk-0 -> /dev/sda;
/dev/disk/by-id/google-pvc-f5418f78-dc07-4d69-9487-6c4a7232dd67 -> /dev/sdb;
/dev/disk/by-id/scsi-0Google_PersistentDisk_persistent-disk-0 -> /dev/sda;
/dev/disk/by-id/scsi-0Google_PersistentDisk_pvc-f5418f78-dc07-4d69-9487-6c4a7232dd67 -> /dev/sdb
@julianKatz
Some doc comment updates
e3a190b
@julianKatz
Add unit tests
7d2a679
@julianKatz
improve partition unit test
1536109
@julianKatz
Log on removal as well
31cf787
@julianKatz
Updated unit tests to be clearer, relying on asserting linkCache
081f515
@julianKatz
Remove unused broken function
e55114a
@julianKatz
Move partition checking into the inner linkcache type. This makes it …
9b5c15d 
…easier to unit test.
@julianKatz
Log when linkcache Run is triggered
e5ec0ce
@julianKatz
New implementation that is hooked into nodestage/unstage. Just linux …
1183e64 
…right now.
@julianKatz
Made a no-op windows implementation of the linkcache package
c925927
@julianKatz
Made test device caches in node_test.go
b4b0c25
@julianKatz
Fix sanity test
97c89a5
@julianKatz
Only warn on failure to create cache
7de39b8
@julianKatz
Only warn on windows instantiation
66b522a
@julianKatz
Make non-implemented on windows an info
ecbda6b
@julianKatz
Improved some error messages to provide better test failure feedback
38851a9
@julianKatz
Always print helpful logs in failing area
45dd677
@julianKatz
Remove now unnecessary corp-helper when running from cloudtop
ffba111
@julianKatz
Only run device cache if successfully created
5e6dcb5
@julianKatz
Replace verbosities
7612520
@cemakd
Add nil checks around the usage of the device cache
ee9172a
@cemakd
Add support for NVMe disk types by using deviceutils
b281364 
Change volumes map to use symlink as key and add volumeID and real
path to the deviceMappings object, this is because there can be
multiple symlinks per volume

Filter out caching and logging info on non pd/hyperdisk volumes

Failure to get real path at add volume time is no longer an error
the real path may be unavailable at this time

Fix the device_windows.go NewDeviceCacheForNode parameters

Add clarifying comments and remove excessive logging

Move wg.Add out of goroutine to fix -verify presubmit
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 30, 2025
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 30, 2025
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2025
@cemakd
Copy link
Contributor

cemakd commented Sep 30, 2025

/approve

@hajiler
Copy link
Contributor

hajiler commented Sep 30, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-arm b281364 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-arm
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 b281364 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022 b281364 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sunnylovestiramisu
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cemakd, hajiler, k8s-infra-cherrypick-robot, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit e6c9004 into kubernetes-sigs:release-1.21 Sep 30, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacaskill amacaskill Awaiting requested review from amacaskill

@pwschuurman pwschuurman Awaiting requested review from pwschuurman

Assignees

@cemakd cemakd

@hajiler hajiler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-infra-cherrypick-robot @cemakd @hajiler @k8s-ci-robot @sunnylovestiramisu @julianKatz