Move parameters and conversion functions to their own packages #2189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR is a follow-up to #2186.
This PR moves the parsing of parameters into their own package:
pkg/parameters
. This is a lot of logic and worthy of its own package.Along the way, I found that
pkg/common
had a number of conversion helper functions (Convert.*
) that were public and occasionally used by both parameters.go and other files, and sometimes only parameters.go. Several of them also had their own unit tests already. Thus, I thought this was also worthy of its own package. This PR thus addspkg/convert
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: