Skip to content

Move parameters and conversion functions to their own packages #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2025
Merged

Move parameters and conversion functions to their own packages #2189

merged 4 commits into from
Oct 7, 2025

Conversation

julianKatz
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR is a follow-up to #2186.

This PR moves the parsing of parameters into their own package: pkg/parameters. This is a lot of logic and worthy of its own package.

Along the way, I found that pkg/common had a number of conversion helper functions (Convert.*) that were public and occasionally used by both parameters.go and other files, and sometimes only parameters.go. Several of them also had their own unit tests already. Thus, I thought this was also worthy of its own package. This PR thus adds pkg/convert.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 7, 2025
@julianKatz julianKatz force-pushed the parameters-in-own-package branch 3 times, most recently from 097769e to eac2b7f Compare October 7, 2025 00:46
@julianKatz julianKatz force-pushed the parameters-in-own-package branch 2 times, most recently from 61ea5ba to 976bdb9 Compare October 7, 2025 20:33
@julianKatz julianKatz force-pushed the parameters-in-own-package branch from 976bdb9 to 6343685 Compare October 7, 2025 20:36
mattcary
mattcary reviewed Oct 7, 2025
View reviewed changes
@julianKatz julianKatz force-pushed the parameters-in-own-package branch from bf688b8 to b3393ff Compare October 7, 2025 21:05
@mattcary
Copy link
Contributor

mattcary commented Oct 7, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julianKatz, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 7, 2025 •
edited
Loading

@julianKatz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-arm b3393ff link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-arm
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 b3393ff link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 967f5c2 into kubernetes-sigs:master Oct 7, 2025
8 of 10 checks passed
@julianKatz julianKatz deleted the parameters-in-own-package branch October 7, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary mattcary left review comments

@pwschuurman pwschuurman Awaiting requested review from pwschuurman

@tonyzhc tonyzhc Awaiting requested review from tonyzhc

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianKatz @mattcary @k8s-ci-robot