Skip to content

Fixed Searchbar overlaps vertical scroll #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

greedy-wudpeckr
Copy link

Summary

Fixed Search-bar that overlaps vertical scroll in pod logs.

Related Issue

Fixes #3018

Changes

before :
Screenshot 2025-07-31 001350

after :
Screenshot 2025-07-31 001329

Steps to reproduce the bug:

Go to pod logs and open search-bar

Signed-off-by: greedy_wudpeckr <[email protected]>
Copy link

linux-foundation-easycla bot commented Jul 30, 2025

CLA Signed

  • ✅login: greedy-wudpeckr / (86f0b49)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested review from illume and sniok July 30, 2025 19:14
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: greedy-wudpeckr
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @greedy-wudpeckr!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 30, 2025
@joaquimrocha
Copy link
Contributor

Thank you!

Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 🎉

A couple of things:

  • Could you amend your commit (and PR title) using an interactive rebase (git rebase -i) to follow our commit guidelines?
  • Could you rebase against main (git checkout main && git pull && git checkout <feature-branch> && git rebase main) and see if the frontend test is still failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searchbar overlaps vertical scroll
4 participants