Skip to content

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Aug 26, 2025

This change fixes an issue in Windows where the search bar in the log viewer overlaps with the scroll on the side.

Fixes: #3018, follow-up from #3721 by @greedy-wudpeckr

Testing

  • Navigate to a pod in Headlamp and click on 'Show Logs'
  • Click on the search icon and note that the search bar does not overlap with scroll
image

@skoeva skoeva self-assigned this Aug 26, 2025
@skoeva skoeva added kind/bug Categorizes issue or PR as related to a bug. frontend Issues related to the frontend LogsViewer labels Aug 26, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from illume and knrt10 August 26, 2025 15:39
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2025
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Thanks @greedy-wudpeckr and @skoeva

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, skoeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2025
@illume illume merged commit 1335bcd into kubernetes-sigs:main Aug 26, 2025
11 of 12 checks passed
@skoeva skoeva deleted the searchbar-overlap branch August 26, 2025 18:32
@illume illume added this to the v0.35.0 milestone Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. frontend Issues related to the frontend kind/bug Categorizes issue or PR as related to a bug. LogsViewer size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searchbar overlaps vertical scroll
3 participants