Frontend Blocker: Storage Pools and Snapshot pages broken due to Headlamp v0.39 CRD rendering crash

[datacore-gjanoti]

This PR is wrt to fix the following issue - #4301

Headlamp v0.39 is crashing when rendering CreateResourceButton for some CRDs
because getMainAPIGroup() is called on an undefined CRD reference.

This PR adds a safe fallback to derive apiVersion without crashing.
The change is minimal and backward-compatible.

Tested locally with v0.39:

• Storage Pools
• Volume Snapshots
• Snapshot Classes

Root Cause Analysis -

CreateResourceButton
↓
ResourceListView
↓
KubeObjectClass.getBaseObject()
↓
makeCustomResourceClass()
↓
customResourceDefinition.getMainAPIGroup() ❌ (was breaking)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: datacore-gjanoti / name: Gaurav Janoti (9d2254b)

[k8s-ci-robot]

Welcome @datacore-gjanoti!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: datacore-gjanoti
Once this PR has been reviewed and has the lgtm label, please assign joaquimrocha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

Fixes a Headlamp v0.39 crash when rendering CRD-backed resource pages by preventing getMainAPIGroup() from being called on an invalid/undefined CRD reference during base-object creation.

Changes:

• Adds a guarded path in makeCustomResourceClass().getBaseObject() to derive apiVersion from the CRD only when it’s present and has getMainAPIGroup().
• Adds a safe fallback to derive apiVersion from the class’ apiVersion when the CRD reference is missing/invalid.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[wfclark5]

++ @ashu8912

[illume]

Thanks for this.

Please check the git commit guidelines in the contributing docs, and look at other git messages with git log to see how they should be formatted.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[illume]

Thanks.

Can you please have a look at changing the git commit message? Also please squash the commits, and rebase against main to remove the merge commit?

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[datacore-gjanoti]

@illume - Thanks for guiding, now I have only one commit (as per Headlamp contribution guidelines)

[datacore-gjanoti]

@illume @ashu8912 please review the PR, I have done the suggested changes.

[datacore-gjanoti]

Rebased on latest upstream/main and force-pushed. The branch is now based on bd7b6ab.
The previous digest verification failure was due to the branch being behind upstream.
Could someone please re-run the CI jobs? @illume @ashu8912

[illume]

Hello again. Sorry, there’s a conflict now… can you please have a look?

[datacore-gjanoti]

@illume @ashu8912 - Rebased on latest upstream/main and resolved the conflicts. Ready for review.