-
Notifications
You must be signed in to change notification settings - Fork 104
Refactor kustomize manifests to keep the same structure as Helm chart #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor kustomize manifests to keep the same structure as Helm chart #1081
Conversation
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @ChenYi015. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Running |
|
Can you provide more details? Like, if you are only moving yaml content around, be explicit about where content "X" was and where it will be and how it makes kustomize consistent with the helm template structure. If you are also adding or removing yaml content, be explicit about it. Also, how is this PR going to help with #824? Is it a subset of #824? |
| .PHONY: manifests | ||
| manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | ||
| $(CONTROLLER_GEN) \ | ||
| rbac:roleName=manager-role output:rbac:artifacts:config=config/components/rbac\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing it? What happens if we modify the rbacs in ./api/... and ./pkg/...?
|
I thought more about this. IMO a better approach is just getting rid of kustomize and use only the helm chart. We can do that if we use the helm chart to generate the release manifest. See #820 (comment) |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
It will make PR #824 easier to review after this refactoring.
Does this PR introduce a user-facing change?