Update k8s dependencies to 1.35#1105
Conversation
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR updates Kubernetes API dependencies from version 1.34 to 1.35, bringing the JobSet SDK in line with the latest Kubernetes release. The changes are primarily auto-generated code updates from the dependency upgrade.
Key Changes
- Updated all k8s.io dependencies from 0.34.x to 0.35.0 in go.mod and go.sum
- Regenerated Python SDK with new Kubernetes API types and fields (WorkloadReference, PodCertificateProjection userAnnotations)
- Updated client-go code with improved WatchList semantics and documentation corrections
- Refreshed CRD definitions with updated field descriptions and new Kubernetes 1.35 features
Reviewed changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated k8s.io dependencies from 0.34.3 to 0.35.0 |
| go.sum | Updated checksums for all dependency version changes including k8s, opentelemetry, golang.org modules |
| sdk/python/jobset/models/io_k8s_api_core_v1_workload_reference.py | Added new WorkloadReference model for k8s 1.35 workload scheduling semantics |
| sdk/python/jobset/models/io_k8s_api_core_v1_pod_spec.py | Added workloadRef field to support new workload scheduling feature |
| sdk/python/jobset/models/io_k8s_api_core_v1_pod_certificate_projection.py | Added userAnnotations field for pod certificate requests |
| sdk/python/jobset/models/io_k8s_api_batch_v1_pod_failure_policy_on_pod_conditions_pattern.py | Changed status field from required to optional |
| sdk/python/jobset/models/io_k8s_api_core_v1_toleration.py | Updated operator description to include Lt and Gt comparison operators |
| sdk/python/jobset/models/io_k8s_api_core_v1_container.py | Updated resizePolicy description to clarify ephemeral container restriction |
| sdk/python/jobset/models/io_k8s_api_batch_v1_job_spec.py | Removed beta-level feature gate documentation from managedBy field |
| sdk/python/test/* | Regenerated test files with updated field structures |
| client-go/informers/externalversions/jobset/v1alpha2/jobset.go | Wrapped ListWatch with ToListWatcherWithWatchListSemantics for improved watch semantics |
| client-go/informers/externalversions/factory.go | Fixed documentation example to use context.WithCancel |
| client-go/clientset/versioned/fake/clientset_generated.go | Fixed typo from 'watchActcion' to 'watchAction' and added IsWatchListSemanticsUnSupported method |
| client-go/applyconfiguration/jobset/v1alpha2/* | Added inline documentation comments to all fields in apply configuration structs |
| hack/python-sdk/swagger.json | Updated Kubernetes API references from v1.34.2 to v1.35.0 |
| config/components/crd/bases/jobset.x-k8s.io_jobsets.yaml | Updated CRD with new k8s 1.35 fields (workloadRef, userAnnotations) and improved descriptions |
| charts/jobset/crds/jobset.x-k8s.io_jobsets.yaml | Mirrored CRD updates for Helm chart |
|
/hold |
|
/retest |
|
@kannon92 I think your problem is this
Could it be that you are already trying to download v1.35 envtest binaries? This should also work, but just since a few minutes since I released v1.35.0 envtest binaries via kubernetes-sigs/controller-tools#1319 |
We got bit hard allowing envtest to roll and not follow controller runtime (golang issues mostly). So right now we pick the envtest that corresponds to the latest release of controller-runtime. |
|
There is a difference between the setup-envtest binary and the envtest binaries (i.e. kube-apiserver, kubectl, etcd). (there is a setup-envtest that corresponds to a CR release, but envtest binaries correspond to Kubernetes releases) setup-envtest is only a binary to download the envtest binaries I think the job failed because setup-envtest was trying to download v1.35.0 envtest binaries before they were published |
|
/hold cancel Thank you @sbueringer for your help here. |
|
/lgtm Great work! |
|
Do you know why we have a default for Line 48 in e94edb8 The infra tests already use the correct value. |
|
good call. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update Kubernetes apis to 0.35.
Keep with latest release.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?