Skip to content

Bump the kubernetes group across 1 directory with 2 updates #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump the kubernetes group across 1 directory with 2 updates #1145

dependabot wants to merge 1 commit into from
+9 −39

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 2, 2026 •
edited
Loading

Bumps the kubernetes group with 1 update in the / directory: sigs.k8s.io/controller-runtime.

Updates sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.1

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.23.1

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.23.0...v0.23.1

v0.23.0

🔆 Highlights

⚠️ Breaking changes

✨ Features

🐛 Bugfixes

... (truncated)

Commits
  • f52bbb8 Merge pull request #3437 from k8s-infra-cherrypick-robot/cherry-pick-3430-to-...
  • 4f41337 Merge pull request #3438 from k8s-infra-cherrypick-robot/cherry-pick-3434-to-...
  • e29a1b9 seedling: Test cache reader waits for cache sync
  • 83c8dc3 bug: Fakeclient: Fix status apply if existing object has managedFields set
  • bf6bcd5 Merge pull request #3436 from k8s-infra-cherrypick-robot/cherry-pick-3431-to-...
  • b6a3a46 bug: Fix panic when using CRs with embedded pointer structs
  • 7866fb0 Merge pull request #3433 from k8s-infra-cherrypick-robot/cherry-pick-3425-to-...
  • 90b26f7 check to see if informer is synced and started before returning cache
  • 129853d Merge pull request #3419 from alvaroaleman/limit-cardinality
  • 00b8b07 🐛 Limit depthWithPriorityMetric cardinality to 25
  • Additional commits viewable in compare view

Updates sigs.k8s.io/structured-merge-diff/v6 from 6.3.1 to 6.3.2-0.20260122202528-d9cc6641c482

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 2, 2026
@netlify
Copy link

netlify bot commented Feb 2, 2026 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit a840be0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-jobset/deploys/6980de782416f800086c5b0b

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign kannon92 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 2, 2026

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 2, 2026
@GiuseppeTT
Copy link
Contributor

GiuseppeTT commented Feb 2, 2026

The upgrade of sigs.k8s.io/controller-runtime is changing the signature of ctrl.NewWebhookManagedBy

go: downloading github.com/moby/term v0.5.0
# sigs.k8s.io/jobset/pkg/webhooks
pkg/webhooks/jobset_webhook.go:103:34: not enough arguments in call to ctrl.NewWebhookManagedBy
	have (controllerruntime.Manager)
	want (manager.Manager, T)
pkg/webhooks/pod_mutating_webhook.go:47:34: not enough arguments in call to ctrl.NewWebhookManagedBy
	have (controllerruntime.Manager)
	want (manager.Manager, T)
# sigs.k8s.io/jobset/pkg/webhooks
# [sigs.k8s.io/jobset/pkg/webhooks]
vet: pkg/webhooks/jobset_webhook.go:103:37: not enough arguments in call to ctrl.NewWebhookManagedBy
	have (controllerruntime.Manager)
	want (manager.Manager, T)
make: *** [Makefile:150: vet] Error 1
+ EXIT_VALUE=2
+ set +o xtrace
Cleaning up after docker in docker.

@andreyvelich
Copy link
Member

andreyvelich commented Feb 2, 2026

Yes, we need to make some changes while migrating to the newer version of controller-runtime.
You can check changes I've done for Trainer: kubeflow/trainer#3127

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 2, 2026

rebase

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dependabot
Bump the kubernetes group across 1 directory with 2 updates
a840be0 
Bumps the kubernetes group with 1 update in the / directory: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).


Updates `sigs.k8s.io/controller-runtime` from 0.22.4 to 0.23.1
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.22.4...v0.23.1)

Updates `sigs.k8s.io/structured-merge-diff/v6` from 6.3.1 to 6.3.2-0.20260122202528-d9cc6641c482
- [Release notes](https://github.com/kubernetes-sigs/structured-merge-diff/releases)
- [Changelog](https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/structured-merge-diff/commits)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.23.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: sigs.k8s.io/structured-merge-diff/v6
  dependency-version: 6.3.2-0.20260122202528-d9cc6641c482
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/kubernetes-e3526076e7 branch from 4ff6528 to a840be0 Compare February 2, 2026 17:27
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2026
@GiuseppeTT
Copy link
Contributor

GiuseppeTT commented Feb 2, 2026

From https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.23.0

Webhooks: Generic Validator and Defaulter by @alvaroaleman in https://github.com/kubernetes-sigs/controller-runtime/pull/3360
Existing code of the form builder.WebhookManagedBy(mgr).For(&corev1.Deployment{}) has to be changed to builder.WebhookManagedBy(mgr, &appsv1.Deployment{})
Existing webhook implementations have to be changed to take the concrete object rather than runtime.Object, for example from ValidateCreate(ctx context.Context, obj runtime.Object) (admission.Warnings, error) to ValidateCreate(ctx context.Context, obj *appsv1.Deployment) (admission.Warnings, error)

@GiuseppeTT
Copy link
Contributor

GiuseppeTT commented Feb 2, 2026

Yes, we need to make some changes while migrating to the newer version of controller-runtime.
You can check changes I've done for Trainer: kubeflow/trainer#3127

Ok!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 2, 2026

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-jobset-test-integration-main a840be0 link true /test pull-jobset-test-integration-main
pull-jobset-verify-main a840be0 link true /test pull-jobset-verify-main
pull-jobset-test-e2e-main-1-33 a840be0 link true /test pull-jobset-test-e2e-main-1-33
pull-jobset-test-e2e-main-1-32 a840be0 link true /test pull-jobset-test-e2e-main-1-32
pull-jobset-test-e2e-main-1-34 a840be0 link true /test pull-jobset-test-e2e-main-1-34
pull-jobset-test-e2e-main-1-35 a840be0 link true /test pull-jobset-test-e2e-main-1-35
pull-jobset-test-unit-main a840be0 link true /test pull-jobset-test-unit-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@GiuseppeTT GiuseppeTT mentioned this pull request Feb 2, 2026
Open
@GiuseppeTT
Copy link
Contributor

GiuseppeTT commented Feb 2, 2026

/hold

I will bump this manually in #1146

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@GiuseppeTT GiuseppeTT Awaiting requested review from GiuseppeTT

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k8s-ci-robot @GiuseppeTT @andreyvelich