feat: Add Drifted condition to NodePool status#2696
feat: Add Drifted condition to NodePool status#2696moko-poi wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moko-poi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @moko-poi. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pull Request Test Coverage Report for Build 20205840409Details
💛 - Coveralls |
963996b to
91d51da
Compare
|
Hi! I've rebased this PR onto the latest main branch and resolved the conflicts. |
Fixes #1785
Description
This PR adds a
Driftedstatus condition to NodePool resources that indicates when any NodeClaims managed by the NodePool have drifted from their desired configuration. This enables external tools like ArgoCD to monitor drift state at the NodePool level for GitOps workflows.Implementation Details:
DriftedNodeClaimresource type to track drifted NodeClaim countsConditionTypeNodeClaimsDriftedconstant to NodePool status conditionsDRIFTEDNODECLAIMSprinter column tokubectl get nodepooloutputTruewhendriftedNodeClaimCount > 0,FalseotherwiseUse Case:
ArgoCD and other GitOps tools can now check the NodePool's Drifted condition to determine if any managed NodeClaims have configuration drift, without needing to query individual NodeClaim resources.
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.