-
Notifications
You must be signed in to change notification settings - Fork 405
feat: Add Pod Disruption Schedule #2745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: jukie <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jukie The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jukie. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Pull Request Test Coverage Report for Build 20545058840Details
💛 - Coveralls |
|
I think we want to think holistically about this space of pod oriented disruption controls, including whether or not these features should land in upstream's PDB. Happy to discuss more in working group. |
|
Having something in upstream PDBs would be great and I can start a KEP or design spec for that as well but in the best case scenario I suspect it'd be over a year before that becomes available. Would you be open to solving this within Karpenter first to figure out the best model which can then be added upstream? Perhaps you'd prefer the CRD approach described in my RFC vs this example? This issues has been open since 2024 along with similar issues describing the desire for more pod-level disruption controls. I agree that we should think holistically about a solution but would also like to get some sense of progress in the area. My proposal would solve a real problem that exists in Karpenter where it's currently unsafe to use do-not-disrupt for anything besides ephemeral workloads that eventually exit on their own and doing so risks violating PDBs upon Nodes reaching max expiration + grace period. As a result of hitting that in the real world I currently maintain a custom controller as a workaround. |
|
I wonder if we might want to consider an alpha API in Karpenters group that is our proposal for an upstream KEP and we target eventually landing it upstream. It might not be able to solve everything (I.e. surge eviction), but could be a good middle ground to get things moving. |
Fixes #1719
Related to #2744 (RFC)
Description
This is a renewal of #1720 and adds the ability to define a pod disruption schedule at the pod-level which behaves somewhat akin to nodepool disruption budgets.
Note: This was mostly AI generated but I have reviewed and understand the implementation. I've built a custom controller that runs alongside Karpenter with similar logic and have previously added this functionality in #1720.
How was this change tested?
Add tests and will run inside a real cluster and update this comment with validation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.