Skip to content

chore: throw errors out of nodeclaim informer loop #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jan 9, 2026
Merged

chore: throw errors out of nodeclaim informer loop #2749

k8s-ci-robot merged 1 commit into from
Jan 9, 2026

Conversation

@DerekFrank
Copy link
Contributor

@DerekFrank DerekFrank commented Dec 30, 2025

Fixes #N/A

Description

This causes the error to get backoff retried instead of just logged

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 30, 2025
@DerekFrank DerekFrank changed the title chore: throw error out of nodeclaim informer loop chore: throw errors out of nodeclaim informer loop Dec 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2025
@DerekFrank DerekFrank force-pushed the cluster-cost-refactor branch from dd6df0a to fb2bfdc Compare December 30, 2025 20:15
moko-poi
moko-poi reviewed Jan 1, 2026
View reviewed changes
@DerekFrank DerekFrank force-pushed the cluster-cost-refactor branch from fb2bfdc to a2b40ba Compare January 2, 2026 19:59
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2026
@coveralls
Copy link

coveralls commented Jan 2, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 20792710508

Details

  • 14 of 20 (70.0%) changed or added relevant lines in 3 files are covered.
  • 17 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 80.654%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/state/informer/pricing.go 2 3 66.67%
pkg/controllers/state/informer/nodeclaim.go 0 2 0.0%
pkg/state/cost/cost.go 12 15 80.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/state/informer/nodeclaim.go 1 65.79%
pkg/controllers/provisioning/scheduling/nodeclaim.go 3 89.63%
pkg/controllers/disruption/consolidation.go 4 88.0%
pkg/state/cost/cost.go 9 72.12%
Totals Coverage Status
Change from base Build 20736781005: 0.2%
Covered Lines: 12007
Relevant Lines: 14887
💛 - Coveralls

DerekFrank
DerekFrank commented Jan 2, 2026
View reviewed changes
Copy link
Contributor Author

@DerekFrank DerekFrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@engedaam
Copy link
Contributor

engedaam commented Jan 2, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2026
@DerekFrank
Copy link
Contributor Author

DerekFrank commented Jan 2, 2026

/retest

ryan-mist
ryan-mist reviewed Jan 6, 2026
View reviewed changes
@DerekFrank DerekFrank force-pushed the cluster-cost-refactor branch from a2b40ba to d2cdf4e Compare January 6, 2026 00:21
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2026
@DerekFrank DerekFrank force-pushed the cluster-cost-refactor branch from d2cdf4e to 76efcc5 Compare January 6, 2026 00:27
ryan-mist
ryan-mist approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@ryan-mist ryan-mist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DerekFrank, moko-poi, ryan-mist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2026
@DerekFrank DerekFrank force-pushed the cluster-cost-refactor branch from 0ce6361 to 76efcc5 Compare January 7, 2026 18:46
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 7, 2026
@engedaam
Copy link
Contributor

engedaam commented Jan 9, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2026
@k8s-ci-robot k8s-ci-robot merged commit 52c3b91 into kubernetes-sigs:main Jan 9, 2026
27 of 28 checks passed
@ryan-mist ryan-mist mentioned this pull request Jan 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@tallaxes tallaxes Awaiting requested review from tallaxes

2 more reviewers

@moko-poi moko-poi moko-poi approved these changes

@ryan-mist ryan-mist ryan-mist approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@engedaam engedaam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DerekFrank @coveralls @engedaam @k8s-ci-robot @moko-poi @ryan-mist