Adding RegistryTLS to the MIC image spec #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIC image spec is being propagated as is to the MBSC image spec. As part of building sign and build pod, one of the inputs is the RegistryTLS configuration used during build/sign process. This PR does the following: 1. Add RegistryTLS field to the ModuleImageSpec 2. module reconciler sets the RegistryTLS in the imageSpec variable 3. changing unit-tests
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
Author
|
/assign @ybettan |
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
- Coverage 79.09% 73.07% -6.02%
==========================================
Files 51 72 +21
Lines 5109 6077 +968
==========================================
+ Hits 4041 4441 +400
- Misses 882 1455 +573
+ Partials 186 181 -5 ☔ View full report in Codecov by Sentry. |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIC image spec is being propagated as is to the MBSC image spec. As part of building sign and build pod, one of the inputs is the RegistryTLS configuration used during build/sign process. This PR does the following: