Introducing buildsign package #1033
Merged
+455
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
/assign @ybettan |
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
- Coverage 79.09% 73.30% -5.80%
==========================================
Files 51 73 +22
Lines 5109 6214 +1105
==========================================
+ Hits 4041 4555 +514
- Misses 882 1471 +589
- Partials 186 188 +2 ☔ View full report in Codecov by Sentry. |
In the current implementation of the build and sign flow, build_sign controller uses 2 packages, build and sign, to verify whether build/sign must be executed, to actually create build/sign pod and to run garbage collector on he successfull pods. In many cases, those 2 packages are very much the same, especially in where the package manager must decide what to do (build pod, delete pod, etc) With the introduction of the MBSC controller, the flow is changing and it makes sense to unify those packages into one package. There is not need to decide if the build/sign should be executed, since that decision is taken by the MIC controller This PR starts with creating the buildsing package and unifying Helper interfaces both in sign and build package into one Helper interface: 1) create Helper interface and implementation for buildsign package 2) move the existing code that was previously using build.Helper and sign.Helper interface to start using unified interface
yevgeny-shnaidman
force-pushed
the
yevgeny/buildsign-helper
branch
from
93f0f8e to
0a0e358
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
cdvultur
pushed a commit
to cdvultur/kernel-module-management
that referenced
this pull request
Oct 22, 2025
…netes-sigs#1033) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.18.0 to 1.19.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.19.0/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.18.0...v1.19.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of the build and sign flow, build_sign controller uses 2 packages, build and sign, to verify whether build/sign must be executed, to actually create build/sign pod and to run garbage collector on he successfull pods. In many cases, those 2 packages are very much the same, especially in where the package manager must decide what to do (build pod, delete pod, etc)
With the introduction of the MBSC controller, the flow is changing and it makes sense to unify those packages into one package. There is not need to decide if the build/sign should be executed, since that decision is taken by the MIC controller
This PR starts with creating the buildsing package and unifying Helper interfaces both in sign and build package into one Helper interface: 1) create Helper interface and implementation for buildsign package 2) move the existing code that was previously using build.Helper and
sign.Helper interface to start using unified interface