Hiding the buildsign porting layer initialization #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
/assign @ybettan |
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
- Coverage 79.09% 74.35% -4.74%
==========================================
Files 51 76 +25
Lines 5109 6739 +1630
==========================================
+ Hits 4041 5011 +970
- Misses 882 1520 +638
- Partials 186 208 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
buildsign/pod is a porting layer, and as such we would like to minimize itsexposure to the outer code. This PR make buildsign manager initialize the maker, signer and buildisngpodmanager interfaces inside its own init function, which will remove the exposure to the porting layer from main
yevgeny-shnaidman
force-pushed
the
yevgeny/hide-porting
branch
from
5f3ad91 to
3891b56
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
cdvultur
pushed a commit
to cdvultur/kernel-module-management
that referenced
this pull request
Oct 22, 2025
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.29.2 to 0.29.3. - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.29.2...v0.29.3) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildsign/pod is a porting layer, and as such we would like to minimize itsexposure to the outer code. This PR make buildsign manager initialize the maker, signer and buildisngpodmanager interfaces inside its own init function, which will remove the exposure to the porting layer from main