Filtering out node heartbeats events for the NMC controller. #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Node heartbeats are there to let the k8s API server that the node is still connected and functional and if not filtered, it will spam the events the NMC controller gets. The NMC controller, is trying to garbage collect pods for NMCs that were removed - it causes a constant reconciliation even when no Module, and therefore no NMC, are applied to the cluster. This commit is fixing this issue. Signed-off-by: Yoni Bettan <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
==========================================
- Coverage 79.09% 74.40% -4.70%
==========================================
Files 51 77 +26
Lines 5109 6880 +1771
==========================================
+ Hits 4041 5119 +1078
- Misses 882 1549 +667
- Partials 186 212 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
cdvultur
pushed a commit
to cdvultur/kernel-module-management
that referenced
this pull request
Oct 22, 2025
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.4+incompatible to 26.0.0+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v25.0.4...v26.0.0) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node heartbeats are there to let the k8s API server that the node is still connected and functional and if not filtered, it will spam the events the NMC controller gets.
The NMC controller, is trying to garbage collect pods for NMCs that were removed - it causes a constant reconciliation even when no Module, and therefore no NMC, are applied to the cluster.
This commit is fixing this issue.
/assign @yevgeny-shnaidman