Switching KMM to work with the new build/sign flow #1060
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
- Coverage 79.09% 74.63% -4.46%
==========================================
Files 51 77 +26
Lines 5109 6865 +1756
==========================================
+ Hits 4041 5124 +1083
- Misses 882 1529 +647
- Partials 186 212 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yevgeny-shnaidman
force-pushed
the
yevgeny/switch-to-mic-mbsc
branch
from
f542188 to
bf14330
Compare
| //[TODO] - update the preflight flow with the MIC/MBSC implementation and then uncomment the preflight conroller | ||
| /* | ||
| preflightStatusUpdaterAPI := preflight.NewStatusUpdater(client) | ||
| preflightAPI := preflight.NewPreflightAPI(client, buildAPI, signAPI, registryAPI, preflightStatusUpdaterAPI, kernelAPI) | ||
| if err = controllers.NewPreflightValidationReconciler(client, filterAPI, metricsAPI, preflightStatusUpdaterAPI, preflightAPI).SetupWithManager(mgr); err != nil { | ||
| cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.PreflightValidationReconcilerName) | ||
| } | ||
| if err = controllers.NewPreflightValidationReconciler(client, filterAPI, metricsAPI, preflightStatusUpdaterAPI, preflightAPI).SetupWithManager(mgr); err != nil { | ||
| cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.PreflightValidationReconcilerName) | ||
| } | ||
| */ |
There was a problem hiding this comment.
Can we do it in the same PR? If you insist on keeping small changes then I would do a multi-commit PR but I think it makes sense to put all of the following inside the same PR and it will be easier for me to review as well:
- Create the new controllers
- Remove the old controllers
- Use the new buildsign pkg everywhere needed
- Remove the old build/sign packages
There was a problem hiding this comment.
it would be better to do it in a separate PR: preflight is not a major priority, and i am not yet sure how many changes i would need to make in order to make it work.
changing the manager's main to use MIC and MBSC reconcilers instead of BuildSignReconciler
yevgeny-shnaidman
force-pushed
the
yevgeny/switch-to-mic-mbsc
branch
from
bf14330 to
3ce9831
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
4 participants
changing the manager's main to use MIC and MBSC reconcilers instead of BuildSignReconciler