Passing the MBSC object as an input to buildsign.Manager interface #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manager interface receives the meta.Object as an input parameter. It passes it to SetControllerReference function, which also expects meta.Object. But inside the function, the it is cast into runtime.Object interface, which requires implementation of DeepCopy function, which is implemented by the whole MBSC object
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
/assign @ybettan |
k8s-ci-robot
added
the
size/S
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
- Coverage 79.09% 74.40% -4.70%
==========================================
Files 51 77 +26
Lines 5109 6880 +1771
==========================================
+ Hits 4041 5119 +1078
- Misses 882 1549 +667
- Partials 186 212 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manager interface receives the meta.Object as an input parameter. It passes it to SetControllerReference function, which also expects meta.Object. But inside the function, the it is cast into runtime.Object interface, which requires implementation of DeepCopy function, which is implemented by the whole MBSC object