Skip to content

Conversation

@yevgeny-shnaidman
Copy link
Contributor

@yevgeny-shnaidman yevgeny-shnaidman commented Mar 30, 2025

Since adding GetPullPodStatus method to the ImagePuller interface,
which returns the status of the Pod based on its Phase, container's status etc',
the MIC controller has no need to look at the pod itself,
but to just pass it to ImagePuller, and act based on the status returned.
In addition, this PR also adds debug logs to updateStatusByMBSC function

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2025
@yevgeny-shnaidman
Copy link
Contributor Author

/assign @ybettan

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2025
@netlify
Copy link

netlify bot commented Mar 30, 2025

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit 70d6b62
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/67ea606782b9360008aa1e99
😎 Deploy Preview https://deploy-preview-1065--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.42%. Comparing base (fa23a9b) to head (70d6b62).
Report is 246 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
- Coverage   79.09%   74.42%   -4.68%     
==========================================
  Files          51       77      +26     
  Lines        5109     6885    +1776     
==========================================
+ Hits         4041     5124    +1083     
- Misses        882     1549     +667     
- Partials      186      212      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ybettan
Copy link
Contributor

ybettan commented Mar 31, 2025

Can we please shorten the commit title (it is leaking).

Also, there is a small typo in the commit message, I would change it to:

Since adding GetPullPodStatus method to the ImgaePuller interface, which returns the status of the Pod based on its Phase, container's status etc', the MIC controller has no need to look at the pod itself, but to just pass it to ImagePuller, and act based on the status returned. In addition, this PR also adds debug logs to updateStatusByMBSC function

Since adding GetPullPodStatus method to the ImagePuller interface,
which returns the status of the Pod based on its Phase, container's status etc',
the MIC controller has no need to look at the pod itself,
but to just pass it to ImagePuller, and act based on the status returned.
In addition, this PR also adds debug logs to updateStatusByMBSC function
@yevgeny-shnaidman yevgeny-shnaidman force-pushed the yevgeny/fix-mic-controller branch from 6665877 to 70d6b62 Compare March 31, 2025 09:29
@yevgeny-shnaidman yevgeny-shnaidman changed the title Changing MIC controller updateStatusByPullPods to support new Changing MIC controller to support new ImagePuller interface Mar 31, 2025
@ybettan
Copy link
Contributor

ybettan commented Mar 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit bb2bfb8 into kubernetes-sigs:main Mar 31, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants