-
Notifications
You must be signed in to change notification settings - Fork 39
Changing MIC controller to support new ImagePuller interface #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing MIC controller to support new ImagePuller interface #1065
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @ybettan |
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 79.09% 74.42% -4.68%
==========================================
Files 51 77 +26
Lines 5109 6885 +1776
==========================================
+ Hits 4041 5124 +1083
- Misses 882 1549 +667
- Partials 186 212 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can we please shorten the commit title (it is leaking). Also, there is a small typo in the commit message, I would change it to:
|
Since adding GetPullPodStatus method to the ImagePuller interface, which returns the status of the Pod based on its Phase, container's status etc', the MIC controller has no need to look at the pod itself, but to just pass it to ImagePuller, and act based on the status returned. In addition, this PR also adds debug logs to updateStatusByMBSC function
6665877 to
70d6b62
Compare
|
/lgtm |
Since adding GetPullPodStatus method to the ImagePuller interface,
which returns the status of the Pod based on its Phase, container's status etc',
the MIC controller has no need to look at the pod itself,
but to just pass it to ImagePuller, and act based on the status returned.
In addition, this PR also adds debug logs to updateStatusByMBSC function