Removing LastTransitionTime from the NMC status.
#1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
- Coverage 79.09% 74.40% -4.70%
==========================================
Files 51 77 +26
Lines 5109 6880 +1771
==========================================
+ Hits 4041 5119 +1078
- Misses 882 1549 +667
- Partials 186 212 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Github runners are being under maintenance - hopefully, CI will be working again soon. |
Since we are now checking if a node has rebooted using the node's `status.nodeInfo.bootID` then we don't need to compare the node's ready time and the NMC last recorded node ready time anymore. Signed-off-by: Yoni Bettan <[email protected]>
k8s-ci-robot
added
size/S
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
Author
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are now checking if a node has rebooted using the node's
status.nodeInfo.bootIDthen we don't need to compare the node's readytime and the NMC last recorded node ready time anymore.
/assign @yevgeny-shnaidman (only the last commit is relevant)
/hold
It should only be merged after #1061
I have tested the upgrade flow and I didn't inspect an issue during the upgrade.