Skip to content

Conversation

@TomerNewman
Copy link
Contributor

@TomerNewman TomerNewman commented May 12, 2025

Following the latest feature addition that allows user to use in-tree kernel module without loaded OOT kernel module, this commit adds documentation for it.


/assign @ybettan
/cc @yevgeny-shnaidman
Relevant feature pr - #1084

@netlify
Copy link

netlify bot commented May 12, 2025

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit 61b7a46
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/682437b31082840008b51332
😎 Deploy Preview https://deploy-preview-1100--kubernetes-sigs-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @TomerNewman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2025
@ybettan
Copy link
Contributor

ybettan commented May 12, 2025

/approve
/ok-to-test
/assign @yevgeny-shnaidman

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.09%. Comparing base (fa23a9b) to head (61b7a46).
Report is 278 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
- Coverage   79.09%   75.09%   -4.01%     
==========================================
  Files          51       76      +25     
  Lines        5109     6845    +1736     
==========================================
+ Hits         4041     5140    +1099     
- Misses        882     1500     +618     
- Partials      186      205      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yevgeny-shnaidman
Copy link
Contributor

Following the latest feature addition that allows KMM to support intree kmods istead of oot, this commit adds documentation for it.

/assign @ybettan /cc @yevgeny-shnaidman Relevant feature pr - #1084

Nit: the commit message is a little bit unclear, lets change it to:
Following the latest feature addition that allows user to use in-tree kernel module without loaded OOT kernel module, this commit adds documentation for it.

Following the latest feature addition that allows user
to use in-tree kernel module without loaded OOT kernel module,
this commit adds documentation for it.
@TomerNewman TomerNewman force-pushed the doc/kmm-support-intree-kmod branch from 8b7c262 to 61b7a46 Compare May 14, 2025 06:26
@ybettan
Copy link
Contributor

ybettan commented May 15, 2025

@yevgeny-shnaidman PTAL

@yevgeny-shnaidman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit c0f149e into kubernetes-sigs:main May 15, 2025
22 checks passed
@TomerNewman TomerNewman deleted the doc/kmm-support-intree-kmod branch June 3, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants