Skip to content

Conversation

krew-release-bot
Copy link
Contributor

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v0.9.8 of pv-mounter on behalf of @fenio.

Thanks,
@krew-release-bot

@ahmetb
Copy link
Member

ahmetb commented Jul 30, 2025

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/pv-mounter.yaml is not a straightforward version bump: change on line 13 does not seem like a version bump: [-]
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2025
@k8s-ci-robot k8s-ci-robot requested a review from chriskim06 July 30, 2025 08:58
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krew-release-bot
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2025
@fenio
Copy link
Contributor

fenio commented Aug 22, 2025

Please simply close this PR. Not sure why it was detected as not version bump but it doesn't matter at this point.
Version v25.34.0 has been already approved and merged so that one here can be safely ignored.

@ahmetb ahmetb closed this Aug 22, 2025
@ahmetb
Copy link
Member

ahmetb commented Aug 22, 2025

@fenio maybe you've re-pushed your tags? v25.34.0 doesn't seem like the version here?

@fenio
Copy link
Contributor

fenio commented Aug 23, 2025

That change was not automatically accepted with reason "change on line 13 does not seem like a version bump". At that point it was simple v0.9.7 to v0.9.8 change. I'd focus on that. Something went wrong here and v25.43.0 made recently is completely different case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants