Fixing search results (#863)

* Fixing search results

* Adding additional search test

* gofmt search_test

Author: wallentx

cmd/krew/cmd/search.go

@@ -38,15 +38,15 @@ type searchItem struct {
 type searchCorpus []searchItem
 
 func (s searchCorpus) descriptions() []string {
-	var res = make([]string, len(s))
+	res := make([]string, 0, len(s))
 	for _, corpus := range s {
 		res = append(res, corpus.description)
 	}
 	return res
 }
 
 func (s searchCorpus) names() []string {
-	var res = make([]string, len(s))
+	res := make([]string, 0, len(s))
 	for _, corpus := range s {
 		res = append(res, corpus.name)
 	}

cmd/krew/cmd/search_test.go

@@ -59,6 +59,16 @@ func Test_searchByNameAndDesc(t *testing.T) {
 			},
 			expected: []string{"baz"},
 		},
+		{
+			keyword: "",
+			names:   []string{"plugin1", "plugin2", "plugin3"}, // empty keyword, only names match
+			descs: []string{
+				"Description for plugin1",
+				"Description for plugin2",
+				"Description for plugin3",
+			},
+			expected: []string{"plugin1", "plugin2", "plugin3"},
+		},
 	}
 
 	for _, tp := range testPlugins {