-
Notifications
You must be signed in to change notification settings - Fork 167
implement ScenarioOperation CRUD logic #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
implement ScenarioOperation CRUD logic #416
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: YamasouA The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @YamasouA. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/cc @ordovicia @utam0k @saza-ku
@sanposhiho: GitHub didn't allow me to request PR reviews from the following users: ordovicia, saza-ku. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good!
count++ | ||
} | ||
if count != 1 { | ||
return fmt.Errorf("validateOperation find some operations") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
return fmt.Errorf("validateOperation find some operations") | |
return fmt.Errorf("exactly one operation type must be specified, but found %d", count) |
@@ -0,0 +1,117 @@ | |||
package v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should at least add the unit tests for this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@utam0k
Thank you for your review.
I add unit test!
/retest |
What type of PR is this?
/area scenario
/kind feature
What this PR does / why we need it:
We implement scenario controller and the webhook.
And this controller and webhook are build as container.
We also implement scenario_operation controller logic.
Which issue(s) this PR fixes:
Part of #396
Special notes for your reviewer:
/label tide/merge-method-squash