🐛 (go/v4,kustomize/v2): Fix problems by simplify scaffold and removing webhookcainjection_patch. Clarifying replacements for cert-manager #4123

camilamacedo86 · 2024-08-31T20:29:10Z

Removed config/default/webhookcainjection_patch.yaml to streamline the scaffold.
Clarified replacements blocks in kustomization.yaml for easier understanding. Each block is now labeled with instructions for uncommenting based on specific webhook scenarios (ValidatingWebhook, DefaultingWebhook, ConvertingWebhook).

Closes: #3538
Closes: #4119

varshaprasad96 · 2024-09-03T02:57:14Z

testdata/project-v4-multigroup-with-deploy-image/config/default/kustomization.yaml

+#     - select:
+#         kind: ValidatingWebhookConfiguration
+#       fieldPaths:
+#         - .metadata.annotations.[cert-manager.io/inject-ca-from]


@camilamacedo86 one question in this - replacements are executed sequentially. If we enable all defaulting, mutating and conversion - wouldn't the annotation be overwritten given the field path is the same?

In our e2e tests, we have enabled all of them. You can see the changes here: Link to GitHub PR (we uncommented all tests, and they work as expected).

Additionally, the paths are different for each configuration. One will replace the ValidatingWebhookConfiguration, another will replace the MutatingWebhookConfiguration, and so on.

Moreover, in the e2e tests for the deploy image sample, we are specifically checking the scenario where only validating webhooks are scaffolded. You can review that here: Link to GitHub Workflow.

However, If you identify any scenarios where this could potentially cause issues, please let us know. We can then add e2e tests to ensure everything is functioning correctly.

/hold

We are working to improve the coverage /tests so that we can ensure this one better

/hold cancel

Now, see that we are testing with e2e all samples under testdata and the tutorial ones
Also, for go/v4 we added a test to validate webhooks when they are applied in a ns that is not the same where the operator and its server is running

So, it is very well covered too.

camilamacedo86 · 2024-09-15T06:09:43Z

c/c @lentzi90

camilamacedo86 · 2024-09-21T12:39:54Z

Hi @erikgb

You might be a good person to help us with the review of this one.
WDYT?

varshaprasad96

/lgtm
/approve

Thanks @camilamacedo86 !

Kavinjsir

Looks good to me!

Nit:
Could we probably remove the code also at:

k8s-ci-robot · 2024-10-11T06:52:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Kavinjsir,camilamacedo86,varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-10-11T11:55:58Z

New changes are detected. LGTM label has been removed.

k8s-ci-robot · 2024-10-11T12:07:46Z

New changes are detected. LGTM label has been removed.

…tch and clarify replacements. - Removed config/default/webhookcainjection_patch.yaml to streamline the scaffold. - Clarified replacements blocks in kustomization.yaml for easier understanding. Each block is now labeled with instructions for uncommenting based on specific webhook scenarios (ValidatingWebhook, DefaultingWebhook, ConvertingWebhook).

In PR kubernetes-sigs#4123, cert-manager CA injection annotations were added directly in the centralized config for ConversionWebhook: - Fields such as `fieldPath: .metadata.namespace` and `fieldPath: .metadata.name` were added to inject the CA into each CRD’s ConversionWebhook. However, this setup is redundant for ConversionWebhooks. Each CRD with a ConversionWebhook already receives the necessary CA injection through a patch managed by cert-manager, making a centralized configuration unnecessary. This commit removes the centralized CA injection configuration for ConversionWebhook to simplify the scaffold and prevent potential duplicate injection issues. Fixes: - Ensures CA injection is handled on a per-CRD basis by cert-manager patches, providing clear, efficient CA management for ConversionWebhooks.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 31, 2024

k8s-ci-robot requested review from Kavinjsir and rashmigottipati August 31, 2024 20:29

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 31, 2024

camilamacedo86 requested a review from varshaprasad96 August 31, 2024 20:30

camilamacedo86 changed the title ~~✨ Simplify scaffold by removing webhookcainjection_patch and clarifying replacements~~ ✨ (go/v4,kustomize/v2): Simplify scaffold by removing webhookcainjection_patch and clarifying replacements Aug 31, 2024

camilamacedo86 changed the title ~~✨ (go/v4,kustomize/v2): Simplify scaffold by removing webhookcainjection_patch and clarifying replacements~~ ✨ (go/v4,kustomize/v2): Simplify scaffold by removing webhookcainjection_patch and clarifying replacements for cert-manager Aug 31, 2024

camilamacedo86 force-pushed the simplify-replaces branch from 924c1fa to 0fcbbdd Compare August 31, 2024 20:34

camilamacedo86 force-pushed the simplify-replaces branch 3 times, most recently from 8d61421 to 146865f Compare August 31, 2024 21:41

camilamacedo86 force-pushed the simplify-replaces branch from 146865f to 34d079d Compare August 31, 2024 21:49

camilamacedo86 mentioned this pull request Sep 1, 2024

✨ (go/v4) Add Metrics Validation and Helper Functions to E2E Tests #4124

Closed

varshaprasad96 reviewed Sep 3, 2024

View reviewed changes

camilamacedo86 force-pushed the simplify-replaces branch 2 times, most recently from a7347f4 to f4df3c6 Compare September 3, 2024 07:15

camilamacedo86 requested a review from varshaprasad96 September 3, 2024 07:22

camilamacedo86 force-pushed the simplify-replaces branch from f4df3c6 to c26de0e Compare September 8, 2024 07:14

camilamacedo86 mentioned this pull request Sep 9, 2024

Add E2E Tests for Applying CR and Webhooks in Non-Default Namespaces #4149

Closed

camilamacedo86 force-pushed the simplify-replaces branch 2 times, most recently from 0ed05fd to bd3991f Compare September 10, 2024 18:57

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2024

camilamacedo86 force-pushed the simplify-replaces branch 2 times, most recently from 495d670 to d0fd88b Compare September 12, 2024 14:04

camilamacedo86 mentioned this pull request Sep 13, 2024

🐛 fix: ensure unique controller names to fix name conflicts in multigroup setup #4162

Merged

camilamacedo86 force-pushed the simplify-replaces branch 3 times, most recently from b252b3b to 2ae2852 Compare September 14, 2024 16:41

camilamacedo86 mentioned this pull request Sep 14, 2024

🌱 e2e-tests: fix/cleanup and add test to validate webhooks outside of the manager namespace #4167

Merged

camilamacedo86 force-pushed the simplify-replaces branch from 2ae2852 to ccce3ae Compare September 15, 2024 06:01

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2024

camilamacedo86 force-pushed the simplify-replaces branch from ccce3ae to 07a6d52 Compare October 2, 2024 05:56

camilamacedo86 mentioned this pull request Oct 2, 2024

✨ Add support to scaffold webhooks for External Types #4203

Merged

varshaprasad96 approved these changes Oct 11, 2024

View reviewed changes

k8s-ci-robot assigned varshaprasad96 Oct 11, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024

Kavinjsir approved these changes Oct 11, 2024

View reviewed changes

camilamacedo86 force-pushed the simplify-replaces branch from 07a6d52 to 8a92032 Compare October 11, 2024 11:55

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024

camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024

camilamacedo86 force-pushed the simplify-replaces branch from 8a92032 to 226981f Compare October 11, 2024 12:07

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024

camilamacedo86 force-pushed the simplify-replaces branch from 226981f to 21e03d5 Compare October 11, 2024 12:14

camilamacedo86 merged commit 7527b0d into kubernetes-sigs:master Oct 11, 2024
23 of 25 checks passed

camilamacedo86 deleted the simplify-replaces branch October 11, 2024 12:37

camilamacedo86 mentioned this pull request Oct 11, 2024

Proposed Changes for 4.3.0 Release #4214

Closed

camilamacedo86 mentioned this pull request Oct 31, 2024

WIP / Ignore for now #4274

Closed

s-urbaniak mentioned this pull request Feb 21, 2025

CLOUDP-294644: remove unneccessary webhook config files mongodb/mongodb-atlas-kubernetes#2144

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🐛 (go/v4,kustomize/v2): Fix problems by simplify scaffold and removing webhookcainjection_patch. Clarifying replacements for cert-manager #4123

🐛 (go/v4,kustomize/v2): Fix problems by simplify scaffold and removing webhookcainjection_patch. Clarifying replacements for cert-manager #4123

Uh oh!

camilamacedo86 commented Aug 31, 2024

Uh oh!

varshaprasad96 Sep 3, 2024

Uh oh!

camilamacedo86 Sep 3, 2024 •

edited

Loading

Uh oh!

camilamacedo86 Sep 10, 2024

Uh oh!

camilamacedo86 Sep 15, 2024

Uh oh!

camilamacedo86 commented Sep 15, 2024

Uh oh!

camilamacedo86 commented Sep 21, 2024

Uh oh!

varshaprasad96 left a comment

Uh oh!

Kavinjsir left a comment

Uh oh!

k8s-ci-robot commented Oct 11, 2024

Uh oh!

k8s-ci-robot commented Oct 11, 2024

Uh oh!

k8s-ci-robot commented Oct 11, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

🐛 (go/v4,kustomize/v2): Fix problems by simplify scaffold and removing webhookcainjection_patch. Clarifying replacements for cert-manager #4123

🐛 (go/v4,kustomize/v2): Fix problems by simplify scaffold and removing webhookcainjection_patch. Clarifying replacements for cert-manager #4123

Uh oh!

Conversation

camilamacedo86 commented Aug 31, 2024

Uh oh!

varshaprasad96 Sep 3, 2024

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Sep 15, 2024

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 commented Sep 15, 2024

Uh oh!

camilamacedo86 commented Sep 21, 2024

Uh oh!

varshaprasad96 left a comment

Choose a reason for hiding this comment

Uh oh!

Kavinjsir left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Oct 11, 2024

Uh oh!

k8s-ci-robot commented Oct 11, 2024

Uh oh!

k8s-ci-robot commented Oct 11, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camilamacedo86 Sep 3, 2024 •

edited

Loading