🌱 ci: add e2e tests for multigroup testdata layout and rename sample #4154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
enhance-ci
branch
2 times, most recently
from
f49e667 to
cae6c7a
Compare
camilamacedo86
changed the title
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
enhance-ci
branch
from
cae6c7a to
34792a4
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
enhance-ci
branch
from
34792a4 to
835844d
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
enhance-ci
branch
from
835844d to
594ce4f
Compare
camilamacedo86
changed the title
camilamacedo86
added
lgtm
camilamacedo86
force-pushed
the
enhance-ci
branch
from
93c3e75 to
c236f20
Compare
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
enhance-ci
branch
from
c236f20 to
7af1845
Compare
We need to rename the name of the sample because of: ```shell The Service "project-v4-multigroup-with-plugins-controller-manager-metrics-service" is invalid: metadata.name: Invalid value: "project-v4-multigroup-with-plugins-controller-manager-metrics-service": must be no more than 63 characters ``` Therefore, in this we are: - Creating jobs to run the e2e tests for all testdata samples in parallel - Renaming the sample project-v4-multigroup-with-plugins to project-v4-multigroup to generate manifests names that can be accepted in k8s
camilamacedo86
force-pushed
the
enhance-ci
branch
from
7af1845 to
3352876
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
This one only add the tests so that we can ensure the default layout and avoid issues like #4161 So, it only need to pass in the e2e tests to be checked, if anyone has a hall for improvements here please feel free to raise a follow up PR but I will not make nobody waste time on reviews of this one and I am moving forward. Either it will support follow up initiatives for we ensure that all is fine. |
camilamacedo86
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to rename the name of the sample because of:
Therefore, in this we are:
PS.: See that it help us for example, found the issue: #4162