✨ (go/v4;helm/alpha-v1;kustomize/v2): Adding default image policy for the manager #4932

adarshagrawal38 · 2025-07-16T09:06:20Z

Adding image pull policy tag to the helm template
Fixing issue: #4859

k8s-ci-robot · 2025-07-16T09:06:29Z

Welcome @adarshagrawal38!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-07-16T09:06:30Z

Hi @adarshagrawal38. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

...lugins/optional/helm/v1alpha/scaffolds/internal/templates/chart-templates/manager/manager.go

adarshagrawal38 · 2025-07-24T15:23:47Z

Hi @camilamacedo86, do we still need this PR?
I see another PR is raised to do same.

camilamacedo86

Hi @camilamacedo86, do we still need this PR?
I see another PR is raised to do same.

We have another PR: #4952 proposal, but it seems to be doing more than should be done by @ronaldosaheki. Therefore, I am unsure if @ronaldosaheki will modify their PR.

Let's speak in the Slack channel kubebuilder.

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go

adarshagrawal38 · 2025-07-31T08:27:11Z

Hi @camilamacedo86 do have any new comments on the PR?

camilamacedo86

@adarshagrawal38

That is great 🎉 to move forward here, we need to squash the commits
We should have 1 PR / 1 solution or fix / 1 commit
Could you please do that?

Also, because the PR title and emojis are used in our release notes
I will update this one accordingly, I hope that you do not mind

/ok-to-test

camilamacedo86 · 2025-07-31T09:53:46Z

Hi @adarshagrawal38

Could you also please rebase it with the master branch?

adarshagrawal38 · 2025-07-31T15:22:30Z

Hi @adarshagrawal38

Could you also please rebase it with the master branch?

Yeah sure did it.

adarshagrawal38 · 2025-07-31T15:25:07Z

@adarshagrawal38

That is great 🎉 to move forward here, we need to squash the commits We should have 1 PR / 1 solution or fix / 1 commit Could you please do that?

Also, because the PR title and emojis are used in our release notes I will update this one accordingly, I hope that you do not mind

/ok-to-test

yeah sure @camilamacedo86 I have updated the PR accordingly,

Thanks for help!

camilamacedo86 · 2025-08-02T08:34:28Z

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go

@@ -31,6 +31,9 @@ type Config struct {

 	// Image is controller manager image name
 	Image string
+
+	// ImagePullPolicy defines the policy to pull the container images
+	ImagePullPolicy string


We do not need it right?
We just need update the manager to have the Image Policy by default
How would we pass this value?

Updated the code to set default values.

camilamacedo86 · 2025-08-03T19:21:28Z

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go

+        {{- if .ImagePullPolicy }}
+        imagePullPolicy: {{ .ImagePullPolicy }}
+        {{- end }}


Suggested change

{{- if .ImagePullPolicy }}

imagePullPolicy: {{ .ImagePullPolicy }}

{{- end }}

imagePullPolicy: "IfNotPresent"

camilamacedo86 · 2025-08-03T19:21:52Z

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go

@@ -31,6 +31,9 @@ type Config struct {

 	// Image is controller manager image name
 	Image string
+
+	// ImagePullPolicy defines the policy to pull the container images
+	ImagePullPolicy string


Suggested change

ImagePullPolicy string

Signed-off-by: Adarsh Agrawal <[email protected]>

camilamacedo86 · 2025-08-04T12:36:56Z

/lgtm
/approved

k8s-ci-robot · 2025-08-04T12:37:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adarshagrawal38, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 16, 2025

k8s-ci-robot requested review from rashmigottipati and varshaprasad96 July 16, 2025 09:06

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2025

adarshagrawal38 mentioned this pull request Jul 16, 2025

Helm plugin add imagePullPolicy field #4859

Open

adarshagrawal38 changed the title ~~Adding image pull policy tag~~ 🐛 Adding image pull policy tag Jul 16, 2025

camilamacedo86 reviewed Jul 16, 2025

View reviewed changes

...lugins/optional/helm/v1alpha/scaffolds/internal/templates/chart-templates/manager/manager.go Show resolved Hide resolved

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2025

ronaldosaheki mentioned this pull request Jul 21, 2025

Improve helmchart template adding fields #4952

Open

camilamacedo86 reviewed Jul 25, 2025

View reviewed changes

camilamacedo86 reviewed Jul 26, 2025

View reviewed changes

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go Outdated Show resolved Hide resolved

camilamacedo86 reviewed Jul 31, 2025

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2025

camilamacedo86 changed the title ~~🐛 Adding image pull policy tag~~ ✨ (go/v4;helm/alpha-v1): Adding default image policy for the manager Jul 31, 2025

camilamacedo86 changed the title ~~✨ (go/v4;helm/alpha-v1): Adding default image policy for the manager~~ ✨ (go/v4;helm/alpha-v1;kustomize/v2): Adding default image policy for the manager Jul 31, 2025

adarshagrawal38 force-pushed the helm-update branch from f5d70fd to b41f7b9 Compare July 31, 2025 15:21

camilamacedo86 reviewed Aug 2, 2025

View reviewed changes

camilamacedo86 reviewed Aug 3, 2025

View reviewed changes

adarshagrawal38 force-pushed the helm-update branch from b41f7b9 to cfa7b7d Compare August 4, 2025 05:10

Adding image pull policy tag for helm chart

3e2e7b9

Signed-off-by: Adarsh Agrawal <[email protected]>

adarshagrawal38 force-pushed the helm-update branch from cfa7b7d to 3e2e7b9 Compare August 4, 2025 08:57

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2025

k8s-ci-robot assigned camilamacedo86 Aug 4, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2025

camilamacedo86 approved these changes Aug 4, 2025

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025

k8s-ci-robot merged commit 98bc8f4 into kubernetes-sigs:master Aug 4, 2025
33 checks passed

✨ (go/v4;helm/alpha-v1;kustomize/v2): Adding default image policy for the manager #4932

✨ (go/v4;helm/alpha-v1;kustomize/v2): Adding default image policy for the manager #4932

Conversation

adarshagrawal38 commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

k8s-ci-robot commented Jul 16, 2025

Uh oh!

Uh oh!

adarshagrawal38 commented Jul 24, 2025

Uh oh!

camilamacedo86 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adarshagrawal38 commented Jul 31, 2025

Uh oh!

camilamacedo86 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 commented Jul 31, 2025

Uh oh!

adarshagrawal38 commented Jul 31, 2025

Uh oh!

adarshagrawal38 commented Jul 31, 2025

Uh oh!

camilamacedo86 Aug 2, 2025

Choose a reason for hiding this comment

Uh oh!

adarshagrawal38 Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

adarshagrawal38 Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

adarshagrawal38 Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 commented Aug 4, 2025

Uh oh!

k8s-ci-robot commented Aug 4, 2025

Uh oh!

Uh oh!

Uh oh!

adarshagrawal38 commented Jul 16, 2025 •

edited

Loading

camilamacedo86 left a comment •

edited

Loading