-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🐛 Enable cert-manager for ci workflow #4985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shubhamag12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Shubhamag12. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
run: | | ||
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager | ||
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager-cainjector | ||
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager-webhook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot do that because it is ONLY required when we have webhooks
Users may need it for the metrics server (We need to check but as far I remember the default approach does not requires certmanager certs, then need to enable it)
So, for now, I think we need to change the Helm Plugin to:
- If it has webhooks OR if we have cert-mangaer uncommented in the config/kustomize, then we add it, uncommented
- If not, we add it commented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, makes sense.
I will work on the suggested approach
This PR is a part of #4977, scenario 6.
Below Jobs were failing because of this since it was trying to look for cert-manager CRDs but they were not configured as it was disabled in CI job workflow:
https://github.com/Shubhamag12/kubebuilder-s6/actions (Run 1)
Adding it in CI workflow
Passed Jobs:
https://github.com/Shubhamag12/kubebuilder-s6/actions (Run 2)