Skip to content

✨ (helm/v2-alpha): Make webhook and metrics ports configurable #5172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

✨ (helm/v2-alpha): Make webhook and metrics ports configurable #5172

merged 1 commit into from
Nov 3, 2025
+767 −34

Conversation

@camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Nov 2, 2025 •
edited
Loading

  • Add configurable webhook.port (default: 9443) and metrics.port (default: 8443) in values.yaml
  • Add comprehensive unit tests for port configuration with default and custom values

Closes: #5172

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 2, 2025
@camilamacedo86
Copy link
Member Author

@defo89 the helm/v2alpha was not released yet
I think it should be part of the initial implementation as well.

So, your request made in: #4802 can be closed with those changes to address it with helm/v2alpha

Please, feel free to help us in the review

@camilamacedo86
Copy link
Member Author

Hi @liam-mackie

Could you please give a hand on the review of this one as well?
Thank you a lot for the help !!

@camilamacedo86 camilamacedo86 mentioned this pull request Nov 2, 2025
Open
@camilamacedo86
✨ (helm/v2-alpha): Make webhook and metrics ports configurable
81a6a7e 
- Add configurable webhook.port (default: 9443) and metrics.port (default: 8443) in values.yaml
- Add comprehensive unit tests for port configuration with default and custom values
liam-mackie
liam-mackie approved these changes Nov 2, 2025
View reviewed changes
Copy link
Contributor

@liam-mackie liam-mackie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Single nit on whether to continue string matching or start marshalling into structures we can traverse programatically a little easier.

pkg/plugins/optional/helm/v2alpha/scaffolds/internal/kustomize/helm_templater.go
// Template webhook ports (9443 by default)
if isWebhook {
// Replace containerPort: 9443 (or any value) for webhook-server with template
if strings.Contains(yamlContent, "webhook-server") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we consider using a similar pattern to the unstructured package and trying to structure the data rather than string matching?

Copy link
Member Author

@camilamacedo86 camilamacedo86 Nov 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could try that, but wouldn’t that apply to whole plugin?
What do you think? Should we check in a follow-up to see if we could improve this horizontally?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - I think that's something we can improve anywhere in the package with some neat generic functions. Once I'm back from Kubecon I'll likely have some more time to contribute, and I'll start implementation. This PR is fine as-is and if we decide to go with a more structured approach, we can refactor the project as a whole :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, liam-mackie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 41ff901 into kubernetes-sigs:master Nov 3, 2025
39 of 40 checks passed
@camilamacedo86 camilamacedo86 deleted the charts-port-congig-v2 branch November 3, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

1 more reviewer

@liam-mackie liam-mackie liam-mackie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-blocker size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camilamacedo86 @k8s-ci-robot @liam-mackie