Include generic Services in Helm v2-alpha chart generation

[UJESH2K]

Fixes #5248

The Helm v2-alpha plugin currently only includes Service resources whose
names contain the substrings "webhook" or "metrics". All other Service
objects found under config/services/ are silently dropped during chart
generation. This results in missing Service definitions in the final Helm
chart, even though these Services are included in the install.yaml produced
by kustomize.

Root Cause

Within resource_organizer.go, Services are only classified under:

• "webhook" (via isWebhookService)
• "metrics" (via isMetricsService)

Any Service that does not match these filters is never added to any group,
and therefore excluded from the final Helm chart output.

Summary of Changes

This PR introduces support for "generic" Services—Service resources that are
neither webhook nor metrics related—by grouping them under a new services
category. This ensures all user-defined Services are included in the Helm
chart.

A new function was added:

// isGenericService determines if a service is neither webhook nor metrics.
func (o *ResourceOrganizer) isGenericService(service *unstructured.Unstructured) bool {
    return !o.isWebhookService(service) && !o.isMetricsService(service)
}

A new collector was added:

// collectGenericServices gathers generic Service resources.
func (o *ResourceOrganizer) collectGenericServices() []*unstructured.Unstructured {
    var generic []*unstructured.Unstructured
    for _, service := range o.resources.Services {
        if o.isGenericService(service) {
            generic = append(generic, service)
        }
    }
    return generic
}

And the main organizer now includes these Services:

genericServices := o.collectGenericServices()
if len(genericServices) > 0 {
    groups["services"] = genericServices
}

✅ Tests Added

This PR also includes a new unit test (generic_services_test.go) that verifies:

• A Service without "webhook" or "metrics" in its name
• is correctly detected as a generic Service
• and is added to the "services" group during chart organization

The test follows the existing Ginkgo/Gomega test structure used by the project.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: UJESH2K / name: UJESH KUMAR YADAV (cbc54fd, cda7069)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: UJESH2K
Once this PR has been reviewed and has the lgtm label, please assign kavinjsir for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @UJESH2K!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @UJESH2K. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Pull request overview

This PR addresses issue #5248 by adding support for generic Service resources in the Helm v2-alpha chart generation. Previously, only Services with "webhook" or "metrics" in their names were included in the generated Helm chart, causing other Service definitions to be silently dropped despite being present in the kustomize install.yaml.

Key Changes

• Added isGenericService() method to identify Services that are neither webhook nor metrics related
• Added collectGenericServices() method to gather these services into a separate group
• Integrated generic services into OrganizeByFunction() under a new "services" category

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new generic services functionality lacks test coverage. While the existing tests verify metrics services (lines 98-124 in chart_converter_test.go), there are no tests verifying that generic services (services without "webhook" or "metrics" in their names) are properly collected, organized into the "services" group, and written to the helm chart.

Consider adding a test case similar to the existing metrics service test that:

1. Creates a service without "webhook" or "metrics" in its name
2. Verifies it's written to dist/chart/templates/services directory
3. Ensures the service is not placed in the webhook or metrics groups

[UJESH2K]

I’ve added a new unit test (generic_services_test.go) that covers the generic Service behavior mentioned here.

The test verifies that a Service without "webhook" or "metrics" in its name is:

• detected as a generic Service

• included in the "services" group

• not placed under "webhook" or "metrics"

This provides test coverage for the new logic introduced in this PR.
Let me know if additional integration-level chart output tests are needed.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The test file is missing the Apache 2.0 copyright header that is present in all other test files in this directory. All test files in this package (suite_test.go, parser_test.go, chart_converter_test.go, helm_templater_test.go) include the standard copyright notice.

[Copilot]

The package declaration uses package kustomize_test which is inconsistent with other test files in this directory. All other test files (chart_converter_test.go, helm_templater_test.go, suite_test.go) use package kustomize. While both approaches are valid in Go, consistency within a package is important for maintainability.

Suggested change

	package kustomize_test
	package kustomize